Refactor finder to work with URL selectors

git/command.go

@@ -6,6 +6,7 @@ import (
 	"errors"
 	"io"
 	"os/exec"
+	"strings"
 
 	"github.com/cli/cli/v2/internal/run"
 )
@@ -48,6 +49,10 @@ func (gc *Command) Output() ([]byte, error) {
 			ge.Stderr = string(exitError.Stderr)
 			ge.ExitCode = exitError.ExitCode()
 		}
+
+		if strings.Contains(ge.Stderr, "fatal: not a git repository") {
+			ge.err = ErrNoGitRepository
+		}
 		err = &ge
 	}
 	return out, err

git/command_test.go

@@ -0,0 +1,98 @@
+package git
+
+import (
+	"fmt"
+	"os"
+	"os/exec"
+	"path/filepath"
+	"runtime"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestOutput(t *testing.T) {
+	tests := []struct {
+		name     string
+		exitCode int
+		stdout   string
+		stderr   string
+		wantErr  error
+	}{
+		{
+			name:     "successful command",
+			stdout:   "hello world",
+			stderr:   "",
+			exitCode: 0,
+			wantErr:  nil,
+		},
+		{
+			name:     "not a repo failure",
+			stdout:   "",
+			stderr:   "fatal: not a git repository (or any of the parent directories): .git",
+			exitCode: 128,
+			wantErr:  ErrNoGitRepository,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+
+			cmd := Command{
+				&exec.Cmd{
+					Path: createMockExecutable(t, tt.stdout, tt.stderr, tt.exitCode),
+				},
+			}
+
+			out, err := cmd.Output()
+			if tt.wantErr != nil {
+				require.Error(t, err)
+				var gitError *GitError
+				require.ErrorAs(t, err, &gitError)
+				assert.Equal(t, tt.wantErr, gitError.err)
+			} else {
+				require.NoError(t, err)
+			}
+			assert.Equal(t, tt.stdout, string(out))
+		})
+	}
+}
+
+func createMockExecutable(t *testing.T, stdout string, stderr string, exitCode int) string {
+	tmpDir := t.TempDir()
+	sourcePath := filepath.Join(tmpDir, "main.go")
+	binaryPath := filepath.Join(tmpDir, "mockexec")
+	if runtime.GOOS == "windows" {
+		binaryPath += ".exe"
+	}
+
+	// Create Go source
+	source := buildCommandSourceCode(exitCode, stdout, stderr)
+
+	// Write source file
+	if err := os.WriteFile(sourcePath, []byte(source), 0600); err != nil {
+		t.Fatal(err)
+	}
+
+	// Compile
+	cmd := exec.Command("go", "build", "-o", binaryPath, sourcePath)
+	if out, err := cmd.CombinedOutput(); err != nil {
+		t.Fatalf("failed to compile: %v\n%s", err, out)
+	}
+	return binaryPath
+
+}
+
+func buildCommandSourceCode(exitCode int, stdout, stderr string) string {
+	return fmt.Sprintf(`package main
+	import (
+		   "fmt"
+		"os"
+	)
+	func main() {
+		fmt.Printf(%q)
+		fmt.Fprintf(os.Stderr, %q)
+		os.Exit(%d)
+	}`, stdout, stderr, exitCode)
+}

git/errors.go

@@ -7,6 +7,7 @@ import (
 
 // ErrNotOnAnyBranch indicates that the user is in detached HEAD state.
 var ErrNotOnAnyBranch = errors.New("git: not on any branch")
+var ErrNoGitRepository = errors.New("git: not in a git repository")
 
 type NotInstalled struct {
 	message string