STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(cache delete): combine test cases for invalid/non-existent refs

Browse source 
Also note that the API never returns HTTP 422 for invalid refs.

Signed-off-by: Babak K. Shandiz <babakks@github.com>
This commit is contained in:
Babak K. Shandiz 2025-08-28 11:07:46 +01:00
parent d1a404a060
commit 08e4aa892e
No known key found for this signature in database
GPG key ID: 9472CAEFF56C742E
1 changed files with 5 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

24
pkg/cmd/cache/delete/delete_test.go vendored
View file

@ -323,34 +323,20 @@ func TestDeleteRun(t *testing.T) {
wantStdout: "",
},
{
name: "invalid ref value returns API error",
opts: DeleteOptions{Identifier: "cache-key", Ref: "invalid-ref"},
stubs: func(reg *httpmock.Registry) {
reg.Register(
httpmock.QueryMatcher("DELETE", "repos/OWNER/REPO/actions/caches", url.Values{
"key": []string{"cache-key"},
"ref": []string{"invalid-ref"},
}),
httpmock.StatusStringResponse(422, `{"message": "Invalid ref format"}`),
)
},
wantErr: true,
wantErrMsg: "X Failed to delete cache: HTTP 422 (https://api.github.com/repos/OWNER/REPO/actions/caches?key=cache-key&ref=invalid-ref)",
},
{
name: "cache key exists but ref not found",
opts: DeleteOptions{Identifier: "existing-cache-key", Ref: "refs/heads/nonexistent-branch"},
// As of now, the API returns HTTP 404 for invalid or non-existent refs.
name: "cache key exists but ref is invalid/not-found",
opts: DeleteOptions{Identifier: "existing-cache-key", Ref: "invalid-ref"},
stubs: func(reg *httpmock.Registry) {
reg.Register(
httpmock.QueryMatcher("DELETE", "repos/OWNER/REPO/actions/caches", url.Values{
"key": []string{"existing-cache-key"},
"ref": []string{"refs/heads/nonexistent-branch"},
"ref": []string{"invalid-ref"},
}),
httpmock.StatusStringResponse(404, ""),
)
},
wantErr: true,
wantErrMsg: "X Could not find a cache matching existing-cache-key (with ref refs/heads/nonexistent-branch) in OWNER/REPO",
wantErrMsg: "X Could not find a cache matching existing-cache-key (with ref invalid-ref) in OWNER/REPO",
},
}