STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor session filtering in listRun function

Browse source 
Simplifies logic for filtering sessions to only include those with valid pull request and repository data. This reduces nested conditionals and improves code readability.
This commit is contained in:
Kynan Ware 2025-08-29 08:25:00 -06:00
parent 0de5cf24f0
commit 0a5b78a510
1 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
pkg/cmd/agent-task/list/list.go
View file

@ -86,21 +86,14 @@ func listRun(opts *ListOptions) error {
cs := opts.IO.ColorScheme()
tp := tableprinter.New(opts.IO, tableprinter.WithHeader("Session ID", "Pull Request", "Repo", "Session State", "Created"))
for _, s := range sessions {
pr := ""
if s.ResourceType == "pull" && s.PullRequest.Number != 0 {
pr = fmt.Sprintf("#%d", s.PullRequest.Number)
} else {
// Skip these sessions in case they happen, for now.
continue
}
repo := ""
if s.PullRequest.Repository != nil && s.PullRequest.Repository.NameWithOwner != "" {
repo = s.PullRequest.Repository.NameWithOwner
} else {
if s.ResourceType != "pull" || s.PullRequest == nil || s.PullRequest.Repository == nil {
// Skip these sessions in case they happen, for now.
continue
}
pr := fmt.Sprintf("#%d", s.PullRequest.Number)
repo := s.PullRequest.Repository.NameWithOwner
// ID
tp.AddField(s.ID)
if tp.IsTTY() {