STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix protocol not being set when token is read from stdin

Browse source
This commit is contained in:
Ilya Trushchenko 2022-08-15 14:12:19 -04:00
parent d4336e0652
commit 0a73192ace
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pkg/cmd/auth/login/login.go
View file

@ -152,7 +152,9 @@ func loginRun(opts *LoginOptions) error {
if err := shared.HasMinimumScopes(httpClient, hostname, opts.Token); err != nil {
return fmt.Errorf("error validating token: %w", err)
}
if opts.GitProtocol != "" {
cfg.Set(hostname, "git_protocol", opts.GitProtocol)
}
return cfg.Write()
}

12
pkg/cmd/auth/login/login_test.go
View file

@ -232,6 +232,18 @@ func Test_loginRun_nontty(t *testing.T) {
},
wantHosts: "github.com:\n oauth_token: abc123\n",
},
{
name: "with token and https git-protocol",
opts: &LoginOptions{
Hostname: "github.com",
Token: "abc123",
GitProtocol: "https",
},
httpStubs: func(reg *httpmock.Registry) {
reg.Register(httpmock.REST("GET", ""), httpmock.ScopesResponder("repo,read:org"))
},
wantHosts: "github.com:\n oauth_token: abc123\n git_protocol: https\n",
},
{
name: "with token and non-default host",
opts: &LoginOptions{