From 137da73642fc66165abf42faa44269c816af08ac Mon Sep 17 00:00:00 2001 From: Harvey Sanders Date: Sun, 3 Sep 2023 20:32:41 -0400 Subject: [PATCH] Simplify mock jobs response --- pkg/cmd/run/view/view_test.go | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/pkg/cmd/run/view/view_test.go b/pkg/cmd/run/view/view_test.go index 1bef02fc3..36d563eee 100644 --- a/pkg/cmd/run/view/view_test.go +++ b/pkg/cmd/run/view/view_test.go @@ -1260,18 +1260,6 @@ func TestViewRun(t *testing.T) { ), }, httpStubs: func(reg *httpmock.Registry) { - jobs := []shared.Job{} - for i := 0; i < 115; i++ { - jobs = append(jobs, shared.Job{ - ID: int64(i), - Name: fmt.Sprintf("job %d", i), - }) - } - - limit := 100 - firstPage := jobs[:limit] - secondPage := jobs[limit:] - reg.Register( httpmock.REST("GET", "repos/OWNER/REPO/actions/runs/3"), httpmock.JSONResponse(shared.SuccessfulRun)) @@ -1281,15 +1269,15 @@ func TestViewRun(t *testing.T) { reg.Register( httpmock.QueryMatcher("GET", "runs/3/jobs", url.Values{"per_page": []string{"100"}}), httpmock.WithHeader( - httpmock.JSONResponse(shared.JobsPayload{TotalCount: len(jobs), Jobs: firstPage}), + httpmock.StringResponse(`{"jobs":[{},{},{}]}`), "Link", `; rel="next", ; rel="last"`), ) reg.Register( httpmock.REST("GET", "runs/3/jobs"), - httpmock.JSONResponse(shared.JobsPayload{TotalCount: len(jobs), Jobs: secondPage})) + httpmock.StringResponse(`{"jobs":[{},{}]}`)) }, - wantOut: "fetched 115 jobs\n", + wantOut: "fetched 5 jobs\n", }, }