From 15770881bb5ba1f706d685e0366cbb718b757aa6 Mon Sep 17 00:00:00 2001 From: Corey Johnson Date: Wed, 27 May 2020 10:08:29 -0700 Subject: [PATCH] Use an array --- command/pr.go | 10 +++++----- command/pr_checkout.go | 2 +- command/pr_diff.go | 2 +- command/pr_lookup.go | 2 +- command/pr_review.go | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/command/pr.go b/command/pr.go index c9cc095d5..4daa2db0a 100644 --- a/command/pr.go +++ b/command/pr.go @@ -315,7 +315,7 @@ func prView(cmd *cobra.Command, args []string) error { return err } - pr, err := prFromArgs(ctx, apiClient, baseRepo, args...) + pr, err := prFromArgs(ctx, apiClient, baseRepo, args) if err != nil { return err } @@ -342,7 +342,7 @@ func prClose(cmd *cobra.Command, args []string) error { return err } - pr, err := prFromArgs(ctx, apiClient, baseRepo, args...) + pr, err := prFromArgs(ctx, apiClient, baseRepo, args) if err != nil { return err } @@ -377,7 +377,7 @@ func prReopen(cmd *cobra.Command, args []string) error { return err } - pr, err := prFromArgs(ctx, apiClient, baseRepo, args...) + pr, err := prFromArgs(ctx, apiClient, baseRepo, args) if err != nil { return err } @@ -414,7 +414,7 @@ func prMerge(cmd *cobra.Command, args []string) error { return err } - pr, err := prFromArgs(ctx, apiClient, baseRepo, args...) + pr, err := prFromArgs(ctx, apiClient, baseRepo, args) if err != nil { return err } @@ -657,7 +657,7 @@ func prReady(cmd *cobra.Command, args []string) error { return err } - pr, err := prFromArgs(ctx, apiClient, baseRepo, args...) + pr, err := prFromArgs(ctx, apiClient, baseRepo, args) if err != nil { return err } diff --git a/command/pr_checkout.go b/command/pr_checkout.go index a8bf710b9..757df0fd5 100644 --- a/command/pr_checkout.go +++ b/command/pr_checkout.go @@ -42,7 +42,7 @@ func prCheckout(cmd *cobra.Command, args []string) error { } } - pr, err := prFromArgs(ctx, apiClient, baseRepo, prString) + pr, err := prFromArgs(ctx, apiClient, baseRepo, []string{prString}) if err != nil { return err } diff --git a/command/pr_diff.go b/command/pr_diff.go index 48ca42bbb..7e2eff78c 100644 --- a/command/pr_diff.go +++ b/command/pr_diff.go @@ -41,7 +41,7 @@ func prDiff(cmd *cobra.Command, args []string) error { return fmt.Errorf("could not determine base repo: %w", err) } - pr, err := prFromArgs(ctx, apiClient, baseRepo, args...) + pr, err := prFromArgs(ctx, apiClient, baseRepo, args) if err != nil { return fmt.Errorf("could not find pull request: %w", err) } diff --git a/command/pr_lookup.go b/command/pr_lookup.go index 6e53cfc54..a5e380b47 100644 --- a/command/pr_lookup.go +++ b/command/pr_lookup.go @@ -12,7 +12,7 @@ import ( "github.com/cli/cli/internal/ghrepo" ) -func prFromArgs(ctx context.Context, apiClient *api.Client, repo ghrepo.Interface, args ...string) (*api.PullRequest, error) { +func prFromArgs(ctx context.Context, apiClient *api.Client, repo ghrepo.Interface, args []string) (*api.PullRequest, error) { if len(args) == 0 { return prForCurrentBranch(ctx, apiClient, repo) } diff --git a/command/pr_review.go b/command/pr_review.go index 3d2d17558..b0a1f2062 100644 --- a/command/pr_review.go +++ b/command/pr_review.go @@ -94,7 +94,7 @@ func prReview(cmd *cobra.Command, args []string) error { return fmt.Errorf("could not determine base repo: %w", err) } - pr, err := prFromArgs(ctx, apiClient, baseRepo, args...) + pr, err := prFromArgs(ctx, apiClient, baseRepo, args) if err != nil { return err }