From 188098d592bd0e17755ef2f234d82a3539fcbb82 Mon Sep 17 00:00:00 2001 From: "Babak K. Shandiz" Date: Sun, 31 Aug 2025 12:25:36 +0100 Subject: [PATCH] test(search): provide feature detection dependency Signed-off-by: Babak K. Shandiz --- pkg/cmd/extension/browse/browse_test.go | 3 ++- pkg/cmd/search/code/code_test.go | 7 ++++--- pkg/search/searcher_test.go | 11 ++++++----- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/pkg/cmd/extension/browse/browse_test.go b/pkg/cmd/extension/browse/browse_test.go index 956ea0fc4..8120da4d3 100644 --- a/pkg/cmd/extension/browse/browse_test.go +++ b/pkg/cmd/extension/browse/browse_test.go @@ -11,6 +11,7 @@ import ( "time" "github.com/cli/cli/v2/internal/config" + fd "github.com/cli/cli/v2/internal/featuredetection" "github.com/cli/cli/v2/internal/gh" "github.com/cli/cli/v2/internal/ghrepo" "github.com/cli/cli/v2/pkg/cmd/repo/view" @@ -125,7 +126,7 @@ func Test_getExtensionRepos(t *testing.T) { }), ) - searcher := search.NewSearcher(client, "github.com") + searcher := search.NewSearcher(client, "github.com", &fd.DisabledDetectorMock{}) emMock := &extensions.ExtensionManagerMock{} emMock.ListFunc = func() []extensions.Extension { return []extensions.Extension{ diff --git a/pkg/cmd/search/code/code_test.go b/pkg/cmd/search/code/code_test.go index efb5f4b57..471a9d0cb 100644 --- a/pkg/cmd/search/code/code_test.go +++ b/pkg/cmd/search/code/code_test.go @@ -7,6 +7,7 @@ import ( "github.com/cli/cli/v2/internal/browser" "github.com/cli/cli/v2/internal/config" + fd "github.com/cli/cli/v2/internal/featuredetection" "github.com/cli/cli/v2/internal/gh" ghmock "github.com/cli/cli/v2/internal/gh/mock" "github.com/cli/cli/v2/pkg/cmdutil" @@ -336,7 +337,7 @@ func TestCodeRun(t *testing.T) { Extension: "go", }, }, - Searcher: search.NewSearcher(nil, "github.com"), + Searcher: search.NewSearcher(nil, "github.com", &fd.DisabledDetectorMock{}), WebMode: true, }, wantBrowse: "https://github.com/search?q=map+path%3Atesting.go&type=code", @@ -354,7 +355,7 @@ func TestCodeRun(t *testing.T) { Extension: ".cpp", }, }, - Searcher: search.NewSearcher(nil, "github.com"), + Searcher: search.NewSearcher(nil, "github.com", &fd.DisabledDetectorMock{}), WebMode: true, }, wantBrowse: "https://github.com/search?q=map+path%3Atesting.cpp&type=code", @@ -381,7 +382,7 @@ func TestCodeRun(t *testing.T) { Extension: "go", }, }, - Searcher: search.NewSearcher(nil, "example.com"), + Searcher: search.NewSearcher(nil, "example.com", &fd.DisabledDetectorMock{}), WebMode: true, }, wantBrowse: "https://example.com/search?q=map+extension%3Ago+filename%3Atesting&type=code", diff --git a/pkg/search/searcher_test.go b/pkg/search/searcher_test.go index fb7bb616a..0af192720 100644 --- a/pkg/search/searcher_test.go +++ b/pkg/search/searcher_test.go @@ -8,6 +8,7 @@ import ( "testing" "github.com/MakeNowJust/heredoc" + fd "github.com/cli/cli/v2/internal/featuredetection" "github.com/cli/cli/v2/pkg/httpmock" "github.com/stretchr/testify/assert" ) @@ -265,7 +266,7 @@ func TestSearcherCode(t *testing.T) { if tt.host == "" { tt.host = "github.com" } - searcher := NewSearcher(client, tt.host) + searcher := NewSearcher(client, tt.host, &fd.DisabledDetectorMock{}) result, err := searcher.Code(tt.query) if tt.wantErr { assert.EqualError(t, err, tt.errMsg) @@ -551,7 +552,7 @@ func TestSearcherCommits(t *testing.T) { if tt.host == "" { tt.host = "github.com" } - searcher := NewSearcher(client, tt.host) + searcher := NewSearcher(client, tt.host, &fd.DisabledDetectorMock{}) result, err := searcher.Commits(tt.query) if tt.wantErr { assert.EqualError(t, err, tt.errMsg) @@ -837,7 +838,7 @@ func TestSearcherRepositories(t *testing.T) { if tt.host == "" { tt.host = "github.com" } - searcher := NewSearcher(client, tt.host) + searcher := NewSearcher(client, tt.host, &fd.DisabledDetectorMock{}) result, err := searcher.Repositories(tt.query) if tt.wantErr { assert.EqualError(t, err, tt.errMsg) @@ -1123,7 +1124,7 @@ func TestSearcherIssues(t *testing.T) { if tt.host == "" { tt.host = "github.com" } - searcher := NewSearcher(client, tt.host) + searcher := NewSearcher(client, tt.host, fd.AdvancedIssueSearchUnsupported()) result, err := searcher.Issues(tt.query) if tt.wantErr { assert.EqualError(t, err, tt.errMsg) @@ -1179,7 +1180,7 @@ func TestSearcherURL(t *testing.T) { if tt.host == "" { tt.host = "github.com" } - searcher := NewSearcher(nil, tt.host) + searcher := NewSearcher(nil, tt.host, nil) assert.Equal(t, tt.url, searcher.URL(tt.query)) }) }