STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix link in version output

Browse source 
It now correctly links to the tagged release instead of to the latest
release.
This commit is contained in:
Mislav Marohnić 2020-12-16 17:07:41 +01:00
parent 04e6446d33
commit 18b19e074d
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
pkg/cmd/version/version.go
View file

@ -26,11 +26,12 @@ func NewCmdVersion(f *cmdutil.Factory, version, buildDate string) *cobra.Command
func Format(version, buildDate string) string {
version = strings.TrimPrefix(version, "v")
var dateStr string
if buildDate != "" {
version = fmt.Sprintf("%s (%s)", version, buildDate)
dateStr = fmt.Sprintf(" (%s)", buildDate)
}
return fmt.Sprintf("gh version %s\n%s\n", version, changelogURL(version))
return fmt.Sprintf("gh version %s%s\n%s\n", version, dateStr, changelogURL(version))
}
func changelogURL(version string) string {

7
pkg/cmd/version/version_test.go
View file

@ -4,6 +4,13 @@ import (
"testing"
)
func TestFormat(t *testing.T) {
expects := "gh version 1.4.0 (2020-12-15)\nhttps://github.com/cli/cli/releases/tag/v1.4.0\n"
if got := Format("1.4.0", "2020-12-15"); got != expects {
t.Errorf("Format() = %q, wants %q", got, expects)
}
}
func TestChangelogURL(t *testing.T) {
tag := "0.3.2"
url := "https://github.com/cli/cli/releases/tag/v0.3.2"