From 1a5e9f1b6120509bfc0e9dac2188b258d72a4589 Mon Sep 17 00:00:00 2001
From: Toshiya Doi <doi.t.npdp@gmail.com>
Date: Fri, 20 Mar 2020 16:32:52 +0900
Subject: [PATCH] Apply table driven testing for pr/issue preview commands

---
 command/issue_test.go | 181 ++++++++++--------------
 command/pr_test.go    | 313 ++++++++++++++----------------------------
 2 files changed, 173 insertions(+), 321 deletions(-)

diff --git a/command/issue_test.go b/command/issue_test.go
index 6d009ca98..3ea2539bf 100644
--- a/command/issue_test.go
+++ b/command/issue_test.go
@@ -281,122 +281,81 @@ func TestIssueView_numberArgWithHash(t *testing.T) {
 	eq(t, url, "https://github.com/OWNER/REPO/issues/123")
 }
 
-func TestIssueView_preview(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/issueView_preview.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	output, err := RunCommand(issueViewCmd, "issue view -p 123")
-	if err != nil {
-		t.Errorf("error running command `issue view`: %v", err)
+func TestIssueView_Preview(t *testing.T) {
+	tests := map[string]struct {
+		ownerRepo       string
+		command         string
+		fixture         string
+		expectedOutputs []*regexp.Regexp
+	}{
+		"Open issue": {
+			ownerRepo: "master",
+			command:   "issue view -p 123",
+			fixture:   "../test/fixtures/issueView_preview.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`ix of coins`),
+				regexp.MustCompile(`Open • marseilles opened about 292 years ago • 9 comments`),
+				regexp.MustCompile(`bold story`),
+				regexp.MustCompile(`View this issue on GitHub: https://github.com/OWNER/REPO/issues/123`),
+			},
+		},
+		"Open issue with no label": {
+			ownerRepo: "master",
+			command:   "issue view -p 123",
+			fixture:   "../test/fixtures/issueView_previewNoLabel.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`ix of coins`),
+				regexp.MustCompile(`Open • marseilles opened about 292 years ago • 9 comments`),
+				regexp.MustCompile(`bold story`),
+				regexp.MustCompile(`View this issue on GitHub: https://github.com/OWNER/REPO/issues/123`),
+			},
+		},
+		"Open issue with empty body": {
+			ownerRepo: "master",
+			command:   "issue view -p 123",
+			fixture:   "../test/fixtures/issueView_previewWithEmptyBody.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`ix of coins`),
+				regexp.MustCompile(`Open • marseilles opened about 292 years ago • 9 comments`),
+				regexp.MustCompile(`View this issue on GitHub: https://github.com/OWNER/REPO/issues/123`),
+			},
+		},
+		"Closed issue": {
+			ownerRepo: "master",
+			command:   "issue view -p 123",
+			fixture:   "../test/fixtures/issueView_previewClosedState.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`ix of coins`),
+				regexp.MustCompile(`Closed • marseilles opened about 292 years ago • 9 comments`),
+				regexp.MustCompile(`bold story`),
+				regexp.MustCompile(`View this issue on GitHub: https://github.com/OWNER/REPO/issues/123`),
+			},
+		},
 	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			initBlankContext("OWNER/REPO", tc.ownerRepo)
+			http := initFakeHTTP()
+			http.StubRepoResponse("OWNER", "REPO")
 
-	eq(t, output.Stderr(), "")
+			jsonFile, _ := os.Open(tc.fixture)
+			defer jsonFile.Close()
+			http.StubResponse(200, jsonFile)
 
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`ix of coins`),
-		regexp.MustCompile(`Open • marseilles opened about 292 years ago • 9 comments`),
-		regexp.MustCompile(`bold story`),
-		regexp.MustCompile(`View this issue on GitHub: https://github.com/OWNER/REPO/issues/123`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
+			output, err := RunCommand(issueViewCmd, tc.command)
+			if err != nil {
+				t.Errorf("error running command `%v`: %v", tc.command, err)
+			}
 
-func TestIssueView_previewNoLabel(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
+			eq(t, output.Stderr(), "")
 
-	jsonFile, _ := os.Open("../test/fixtures/issueView_previewNoLabel.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	output, err := RunCommand(issueViewCmd, "issue view -p 123")
-	if err != nil {
-		t.Errorf("error running command `issue view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`ix of coins`),
-		regexp.MustCompile(`Open • marseilles opened about 292 years ago • 9 comments`),
-		regexp.MustCompile(`bold story`),
-		regexp.MustCompile(`View this issue on GitHub: https://github.com/OWNER/REPO/issues/123`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
-
-func TestIssueView_previewClosedState(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/issueView_previewClosedState.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	output, err := RunCommand(issueViewCmd, "issue view -p 123")
-	if err != nil {
-		t.Errorf("error running command `issue view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`ix of coins`),
-		regexp.MustCompile(`Closed • marseilles opened about 292 years ago • 9 comments`),
-		regexp.MustCompile(`bold story`),
-		regexp.MustCompile(`View this issue on GitHub: https://github.com/OWNER/REPO/issues/123`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
-
-func TestIssueView_previewWithEmptyBody(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/issueView_previewWithEmptyBody.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	output, err := RunCommand(issueViewCmd, "issue view -p 123")
-	if err != nil {
-		t.Errorf("error running command `issue view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`ix of coins`),
-		regexp.MustCompile(`Open • marseilles opened about 292 years ago • 9 comments`),
-		regexp.MustCompile(`View this issue on GitHub: https://github.com/OWNER/REPO/issues/123`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
+			for _, r := range tc.expectedOutputs {
+				if !r.MatchString(output.String()) {
+					t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
+					return
+				}
+			}
+		})
 	}
 }
 
diff --git a/command/pr_test.go b/command/pr_test.go
index 27f0a064d..d3864a046 100644
--- a/command/pr_test.go
+++ b/command/pr_test.go
@@ -384,222 +384,115 @@ func TestPRList_filteringAssigneeLabels(t *testing.T) {
 	}
 }
 
-func TestPRView_previewOpenState(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/prViewPreview.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	output, err := RunCommand(prViewCmd, "pr view -p 12")
-	if err != nil {
-		t.Errorf("error running command `pr view`: %v", err)
+func TestPRView_Preview(t *testing.T) {
+	tests := map[string]struct {
+		ownerRepo       string
+		args            string
+		fixture         string
+		expectedOutputs []*regexp.Regexp
+	}{
+		"Open PR": {
+			ownerRepo: "master",
+			args:      "pr view -p 12",
+			fixture:   "../test/fixtures/prViewPreview.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`Blueberries are from a fork`),
+				regexp.MustCompile(`Open • nobody wants to merge 12 commits into master from blueberries`),
+				regexp.MustCompile(`blueberries taste good`),
+				regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12`),
+			},
+		},
+		"Open PR for the current branch": {
+			ownerRepo: "blueberries",
+			args:      "pr view -p",
+			fixture:   "../test/fixtures/prView.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`Blueberries are a good fruit`),
+				regexp.MustCompile(`Open • nobody wants to merge 8 commits into master from blueberries`),
+				regexp.MustCompile(`blueberries taste good`),
+				regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/10`),
+			},
+		},
+		"Open PR wth empty body for the current branch": {
+			ownerRepo: "blueberries",
+			args:      "pr view -p",
+			fixture:   "../test/fixtures/prView_EmptyBody.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`Blueberries are a good fruit`),
+				regexp.MustCompile(`Open • nobody wants to merge 8 commits into master from blueberries`),
+				regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/10`),
+			},
+		},
+		"Closed PR": {
+			ownerRepo: "master",
+			args:      "pr view -p 12",
+			fixture:   "../test/fixtures/prViewPreviewClosedState.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`Blueberries are from a fork`),
+				regexp.MustCompile(`Closed • nobody wants to merge 12 commits into master from blueberries`),
+				regexp.MustCompile(`blueberries taste good`),
+				regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12`),
+			},
+		},
+		"Merged PR": {
+			ownerRepo: "master",
+			args:      "pr view -p 12",
+			fixture:   "../test/fixtures/prViewPreviewMergedState.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`Blueberries are from a fork`),
+				regexp.MustCompile(`Merged • nobody wants to merge 12 commits into master from blueberries`),
+				regexp.MustCompile(`blueberries taste good`),
+				regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12`),
+			},
+		},
+		"Draft PR": {
+			ownerRepo: "master",
+			args:      "pr view -p 12",
+			fixture:   "../test/fixtures/prViewPreviewDraftState.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`Blueberries are from a fork`),
+				regexp.MustCompile(`Draft • nobody wants to merge 12 commits into master from blueberries`),
+				regexp.MustCompile(`blueberries taste good`),
+				regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12`),
+			},
+		},
+		"Draft PR by branch": {
+			ownerRepo: "master",
+			args:      "pr view -p blueberries",
+			fixture:   "../test/fixtures/prViewPreviewDraftStatebyBranch.json",
+			expectedOutputs: []*regexp.Regexp{
+				regexp.MustCompile(`Blueberries are a good fruit`),
+				regexp.MustCompile(`Draft • nobody wants to merge 8 commits into master from blueberries`),
+				regexp.MustCompile(`blueberries taste good`),
+				regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/10`),
+			},
+		},
 	}
 
-	eq(t, output.Stderr(), "")
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			initBlankContext("OWNER/REPO", tc.ownerRepo)
+			http := initFakeHTTP()
+			http.StubRepoResponse("OWNER", "REPO")
 
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`Blueberries are from a fork`),
-		regexp.MustCompile(`Open • nobody wants to merge 12 commits into master from blueberries`),
-		regexp.MustCompile(`blueberries taste good`),
-		regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
+			jsonFile, _ := os.Open(tc.fixture)
+			defer jsonFile.Close()
+			http.StubResponse(200, jsonFile)
 
-func TestPRView_previewClosedState(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
+			output, err := RunCommand(prViewCmd, tc.args)
+			if err != nil {
+				t.Errorf("error running command `%v`: %v", tc.args, err)
+			}
 
-	jsonFile, _ := os.Open("../test/fixtures/prViewPreviewClosedState.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
+			eq(t, output.Stderr(), "")
 
-	output, err := RunCommand(prViewCmd, "pr view -p 12")
-	if err != nil {
-		t.Errorf("error running command `pr view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`Blueberries are from a fork`),
-		regexp.MustCompile(`Closed • nobody wants to merge 12 commits into master from blueberries`),
-		regexp.MustCompile(`blueberries taste good`),
-		regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
-
-func TestPRView_previewMergedState(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/prViewPreviewMergedState.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	output, err := RunCommand(prViewCmd, "pr view -p 12")
-	if err != nil {
-		t.Errorf("error running command `pr view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`Blueberries are from a fork`),
-		regexp.MustCompile(`Merged • nobody wants to merge 12 commits into master from blueberries`),
-		regexp.MustCompile(`blueberries taste good`),
-		regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
-
-func TestPRView_previewDraftState(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/prViewPreviewDraftState.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	output, err := RunCommand(prViewCmd, "pr view -p 12")
-	if err != nil {
-		t.Errorf("error running command `pr view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`Blueberries are from a fork`),
-		regexp.MustCompile(`Draft • nobody wants to merge 12 commits into master from blueberries`),
-		regexp.MustCompile(`blueberries taste good`),
-		regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/12`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
-
-func TestPRView_previewCurrentBranch(t *testing.T) {
-	initBlankContext("OWNER/REPO", "blueberries")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/prView.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	restoreCmd := utils.SetPrepareCmd(func(cmd *exec.Cmd) utils.Runnable {
-		return &test.OutputStub{}
-	})
-	defer restoreCmd()
-
-	output, err := RunCommand(prViewCmd, "pr view -p")
-	if err != nil {
-		t.Errorf("error running command `pr view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`Blueberries are a good fruit`),
-		regexp.MustCompile(`Open • nobody wants to merge 8 commits into master from blueberries`),
-		regexp.MustCompile(`blueberries taste good`),
-		regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/10`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
-
-func TestPRView_previewDraftStatebyBranch(t *testing.T) {
-	initBlankContext("OWNER/REPO", "master")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/prViewPreviewDraftStatebyBranch.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	output, err := RunCommand(prViewCmd, "pr view -p blueberries")
-	if err != nil {
-		t.Errorf("error running command `pr view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`Blueberries are a good fruit`),
-		regexp.MustCompile(`Draft • nobody wants to merge 8 commits into master from blueberries`),
-		regexp.MustCompile(`blueberries taste good`),
-		regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/10`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
-	}
-}
-
-func TestPRView_previewCurrentBranchWithEmptyBody(t *testing.T) {
-	initBlankContext("OWNER/REPO", "blueberries")
-	http := initFakeHTTP()
-	http.StubRepoResponse("OWNER", "REPO")
-
-	jsonFile, _ := os.Open("../test/fixtures/prView_EmptyBody.json")
-	defer jsonFile.Close()
-	http.StubResponse(200, jsonFile)
-
-	restoreCmd := utils.SetPrepareCmd(func(cmd *exec.Cmd) utils.Runnable {
-		return &test.OutputStub{}
-	})
-	defer restoreCmd()
-
-	output, err := RunCommand(prViewCmd, "pr view -p")
-	if err != nil {
-		t.Errorf("error running command `pr view`: %v", err)
-	}
-
-	eq(t, output.Stderr(), "")
-
-	expectedLines := []*regexp.Regexp{
-		regexp.MustCompile(`Blueberries are a good fruit`),
-		regexp.MustCompile(`Open • nobody wants to merge 8 commits into master from blueberries`),
-		regexp.MustCompile(`View this pull request on GitHub: https://github.com/OWNER/REPO/pull/10`),
-	}
-	for _, r := range expectedLines {
-		if !r.MatchString(output.String()) {
-			t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
-			return
-		}
+			for _, r := range tc.expectedOutputs {
+				if !r.MatchString(output.String()) {
+					t.Errorf("output did not match regexp /%s/\n> output\n%s\n", r, output)
+					return
+				}
+			}
+		})
 	}
 }