From 1a9704dbfb58db378e62025c2607360b997eb89a Mon Sep 17 00:00:00 2001 From: ttran112 Date: Sat, 5 Jun 2021 22:46:46 -0700 Subject: [PATCH] fix the route --- pkg/cmd/browse/browse.go | 7 +------ pkg/cmd/root/root.go | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go index c1b5c8592..90f0ac9bb 100644 --- a/pkg/cmd/browse/browse.go +++ b/pkg/cmd/browse/browse.go @@ -31,7 +31,6 @@ type BrowseOptions struct { WikiFlag bool SettingsFlag bool BranchFlag bool - //LineFlag bool } type exitCode int @@ -139,7 +138,6 @@ func openInBrowser(cmd *cobra.Command, opts *BrowseOptions) error { } return printExit(response, cmd, opts, repoUrl) - } func addCombined(opts *BrowseOptions, url string, branchName string) (exitCode, string) { @@ -158,7 +156,6 @@ func addCombined(opts *BrowseOptions, url string, branchName string) (exitCode, } return exitUrlSuccess, url + "/tree/" + opts.AdditionalArg + "/" + arr[0] - } func addFlag(opts *BrowseOptions, url string) (exitCode, string) { @@ -169,7 +166,7 @@ func addFlag(opts *BrowseOptions, url string) (exitCode, string) { } else if opts.WikiFlag { return exitUrlSuccess, url + "/wiki" } - return exitExpectedArg, "" // Flag is a branch and needs an argument + return exitExpectedArg, "" } func addArg(opts *BrowseOptions, url string, branchName string) (exitCode, string) { @@ -204,10 +201,8 @@ func printExit(exit exitCode, cmd *cobra.Command, opts *BrowseOptions, url strin switch exit { case exitUrlSuccess: fmt.Fprintf(w, "now opening %s in browser . . .\n", cs.Bold(url)) - break case exitNonUrlSuccess: fmt.Fprintf(w, "now opening issue/pr in browser . . .\n") - break case exitNotInRepo: return fmt.Errorf("change directory to a repository to open in browser\n%s", help) case exitTooManyFlags: diff --git a/pkg/cmd/root/root.go b/pkg/cmd/root/root.go index 76099a4b7..17b91ea81 100644 --- a/pkg/cmd/root/root.go +++ b/pkg/cmd/root/root.go @@ -96,7 +96,7 @@ func NewCmdRoot(f *cmdutil.Factory, version, buildDate string) *cobra.Command { repoResolvingCmdFactory := *f repoResolvingCmdFactory.BaseRepo = resolvedBaseRepo(f) - cmd.AddCommand(browseCmd.NewCmdBrowse(f)) // adds to the commands Commands() + cmd.AddCommand(browseCmd.NewCmdBrowse(&repoResolvingCmdFactory)) // adds to the commands Commands() cmd.AddCommand(prCmd.NewCmdPR(&repoResolvingCmdFactory)) cmd.AddCommand(issueCmd.NewCmdIssue(&repoResolvingCmdFactory)) cmd.AddCommand(releaseCmd.NewCmdRelease(&repoResolvingCmdFactory))