From 1ad9b0b14e97684def27645fe4b08b179efa41ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mislav=20Marohni=C4=87?= Date: Thu, 3 Sep 2020 15:35:07 +0200 Subject: [PATCH] Have `FindDraftRelease` be truer to its name --- pkg/cmd/release/shared/fetch.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/release/shared/fetch.go b/pkg/cmd/release/shared/fetch.go index 7e233fb6b..4cc31ff48 100644 --- a/pkg/cmd/release/shared/fetch.go +++ b/pkg/cmd/release/shared/fetch.go @@ -113,7 +113,7 @@ func FetchLatestRelease(httpClient *http.Client, baseRepo ghrepo.Interface) (*Re return &release, nil } -// FindDraftRelease interates over all releases in a repository until it finds one that matches tagName. +// FindDraftRelease returns the latest draft release that matches tagName. func FindDraftRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagName string) (*Release, error) { path := fmt.Sprintf("repos/%s/%s/releases", baseRepo.RepoOwner(), baseRepo.RepoName()) url := ghinstance.RESTPrefix(baseRepo.RepoHost()) + path @@ -148,7 +148,7 @@ func FindDraftRelease(httpClient *http.Client, baseRepo ghrepo.Interface, tagNam } for _, r := range releases { - if r.TagName == tagName { + if r.IsDraft && r.TagName == tagName { return &r, nil } }