From 1bba50b3e01212bc7663ceceeb50c455e9fc94b4 Mon Sep 17 00:00:00 2001 From: Kynan Ware <47394200+BagToad@users.noreply.github.com> Date: Thu, 5 Mar 2026 15:44:25 -0700 Subject: [PATCH] Fix duplicate reviewers in gh pr edit by passing logins as defaults Use DefaultLogins instead of Default display names when calling MultiSelectWithSearch for reviewers. The dedup logic in the prompter compares keys (logins) against defaults, so passing display names like 'mxie (Melissa Xie)' prevented deduplication against search result keys like 'mxie'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- pkg/cmd/pr/shared/editable.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/pr/shared/editable.go b/pkg/cmd/pr/shared/editable.go index 31b253d9b..1b7c42be3 100644 --- a/pkg/cmd/pr/shared/editable.go +++ b/pkg/cmd/pr/shared/editable.go @@ -317,7 +317,7 @@ func EditFieldsSurvey(p EditPrompter, editable *Editable, editorCommand string) editable.Reviewers.Value, err = p.MultiSelectWithSearch( "Reviewers", "Search reviewers", - editable.Reviewers.Default, + editable.Reviewers.DefaultLogins, // No persistent options - teams are included in search results []string{}, editable.ReviewerSearchFunc)