From 1d506f533111dfeebd14b086474d0e8cacfac84d Mon Sep 17 00:00:00 2001 From: lif <1835304752@qq.com> Date: Wed, 14 Jan 2026 18:35:04 +0800 Subject: [PATCH] fix: simplify set-default remote parsing --- pkg/cmd/repo/setdefault/setdefault.go | 4 ---- pkg/cmd/repo/setdefault/setdefault_test.go | 9 ++++++++- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/pkg/cmd/repo/setdefault/setdefault.go b/pkg/cmd/repo/setdefault/setdefault.go index 71c993b9d..d4abac309 100644 --- a/pkg/cmd/repo/setdefault/setdefault.go +++ b/pkg/cmd/repo/setdefault/setdefault.go @@ -92,10 +92,6 @@ func NewCmdSetDefault(f *cmdutil.Factory, runF func(*SetDefaultOptions) error) * var err error opts.Repo, err = ghrepo.FromFullName(args[0]) if err != nil { - if opts.Remotes == nil { - return fmt.Errorf("given arg is not a valid repo or git remote: %w", err) - } - remotes, remoteErr := opts.Remotes() if remoteErr != nil { return remoteErr diff --git a/pkg/cmd/repo/setdefault/setdefault_test.go b/pkg/cmd/repo/setdefault/setdefault_test.go index eb8d6282c..5b2c4d6a3 100644 --- a/pkg/cmd/repo/setdefault/setdefault_test.go +++ b/pkg/cmd/repo/setdefault/setdefault_test.go @@ -116,10 +116,17 @@ func TestNewCmdSetDefault(t *testing.T) { io.SetStdoutTTY(true) io.SetStdinTTY(true) io.SetStderrTTY(true) + remotesFunc := tt.remotes + if remotesFunc == nil { + remotesFunc = func() (context.Remotes, error) { + return context.Remotes{}, nil + } + } + f := &cmdutil.Factory{ IOStreams: io, GitClient: &git.Client{GitPath: "/fake/path/to/git"}, - Remotes: tt.remotes, + Remotes: remotesFunc, } var gotOpts *SetDefaultOptions