STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge issuesV2Flags cases into TestNewCmdCreate

Browse source 
The five Issues 2.0 cases (type, parent by number, parent by URL,
blocked-by, blocking) live as a separate parallel test today. They
exercise the same NewCmdCreate code path as the existing cases, so
fold them into TestNewCmdCreate and extend the assertions to cover
IssueType, Parent, BlockedBy, and Blocking.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Kynan Ware 2026-05-06 16:22:45 -06:00
parent 5987cb3be4
commit 201eb7ec5e
1 changed files with 59 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

132
pkg/cmd/issue/create/create_test.go
View file

@ -198,6 +198,61 @@ func TestNewCmdCreate(t *testing.T) {
cli: "--editor",
wantsErr: true,
},
{
name: "type",
tty: false,
cli: `-t mytitle -b mybody --type Bug`,
wantsErr: false,
wantsOpts: CreateOptions{
Title: "mytitle",
Body: "mybody",
IssueType: "Bug",
},
},
{
name: "parent by number",
tty: false,
cli: `-t mytitle -b mybody --parent 100`,
wantsErr: false,
wantsOpts: CreateOptions{
Title: "mytitle",
Body: "mybody",
Parent: "100",
},
},
{
name: "parent by URL",
tty: false,
cli: `-t mytitle -b mybody --parent https://github.com/cli/go-gh/issues/42`,
wantsErr: false,
wantsOpts: CreateOptions{
Title: "mytitle",
Body: "mybody",
Parent: "https://github.com/cli/go-gh/issues/42",
},
},
{
name: "blocked by multiple issues",
tty: false,
cli: `-t mytitle -b mybody --blocked-by 200,201`,
wantsErr: false,
wantsOpts: CreateOptions{
Title: "mytitle",
Body: "mybody",
BlockedBy: []string{"200", "201"},
},
},
{
name: "blocking another issue",
tty: false,
cli: `-t mytitle -b mybody --blocking 300`,
wantsErr: false,
wantsOpts: CreateOptions{
Title: "mytitle",
Body: "mybody",
Blocking: []string{"300"},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
@ -247,6 +302,10 @@ func TestNewCmdCreate(t *testing.T) {
assert.Equal(t, tt.wantsOpts.WebMode, opts.WebMode)
assert.Equal(t, tt.wantsOpts.Interactive, opts.Interactive)
assert.Equal(t, tt.wantsOpts.Template, opts.Template)
assert.Equal(t, tt.wantsOpts.IssueType, opts.IssueType)
assert.Equal(t, tt.wantsOpts.Parent, opts.Parent)
assert.Equal(t, tt.wantsOpts.BlockedBy, opts.BlockedBy)
assert.Equal(t, tt.wantsOpts.Blocking, opts.Blocking)
})
}
}
@ -1260,79 +1319,6 @@ func TestIssueCreate_projectsV2(t *testing.T) {
assert.Equal(t, "https://github.com/OWNER/REPO/issues/12\n", output.String())
}
func TestNewCmdCreate_issuesV2Flags(t *testing.T) {
tests := []struct {
name string
cli string
wantsErr bool
wantsType string
wantsParent string
wantsBlocking []string
wantsBlockBy []string
}{
{
name: "type flag",
cli: `-t mytitle -b mybody --type Bug`,
wantsType: "Bug",
},
{
name: "parent flag with number",
cli: `-t mytitle -b mybody --parent 100`,
wantsParent: "100",
},
{
name: "parent flag with URL",
cli: `-t mytitle -b mybody --parent https://github.com/cli/go-gh/issues/42`,
wantsParent: "https://github.com/cli/go-gh/issues/42",
},
{
name: "blocked-by flag",
cli: `-t mytitle -b mybody --blocked-by 200,201`,
wantsBlockBy: []string{"200", "201"},
},
{
name: "blocking flag",
cli: `-t mytitle -b mybody --blocking 300`,
wantsBlocking: []string{"300"},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ios, _, _, _ := iostreams.Test()
f := &cmdutil.Factory{
IOStreams: ios,
Config: func() (gh.Config, error) {
return config.NewBlankConfig(), nil
},
}
var opts *CreateOptions
cmd := NewCmdCreate(f, func(o *CreateOptions) error {
opts = o
return nil
})
args, err := shlex.Split(tt.cli)
require.NoError(t, err)
cmd.SetArgs(args)
cmd.SetOut(io.Discard)
cmd.SetErr(io.Discard)
_, err = cmd.ExecuteC()
if tt.wantsErr {
assert.Error(t, err)
return
}
require.NoError(t, err)
assert.Equal(t, tt.wantsType, opts.IssueType)
assert.Equal(t, tt.wantsParent, opts.Parent)
assert.Equal(t, tt.wantsBlocking, opts.Blocking)
assert.Equal(t, tt.wantsBlockBy, opts.BlockedBy)
})
}
}
func Test_createRun_issuesV2(t *testing.T) {
tests := []struct {
name string