STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pr bug/rest-204 review feedback

Browse source
This commit is contained in:
gertd 2020-04-10 16:48:11 -07:00
parent b9f1b5dac1
commit 203525c031
3 changed files with 15 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
api/client.go
View file

@ -146,7 +146,7 @@ func (c Client) REST(method string, p string, body io.Reader, data interface{})
return handleHTTPError(resp)
}
if resp.StatusCode == http.StatusNoContent && resp.ContentLength == 0 {
if resp.StatusCode == http.StatusNoContent {
return nil
}

23
api/client_rest_test.go
View file

@ -1,23 +0,0 @@
package api
import (
"bytes"
"testing"
)
func TestRESTGetDelete(t *testing.T) {
http := &FakeHTTP{}
client := NewClient(
ReplaceTripper(http),
AddHeader("Authorization", "Basic BASE64ENCODE_CLIENT_ID:CLIENT_SECRET"),
AddHeader("Content-Type", "text/plain"),
)
http.StubResponse(204, bytes.NewBuffer([]byte{}))
r := bytes.NewReader([]byte(`{"access_token": "ACCESS_TOKEN"}`))
var data interface{}
err := client.REST("DELETE", "applications/CLIENTID/grant", r, &data)
eq(t, err, nil)
}

14
api/client_test.go
View file

@ -50,3 +50,17 @@ func TestGraphQLError(t *testing.T) {
t.Fatalf("got %q", err.Error())
}
}
func TestRESTGetDelete(t *testing.T) {
http := &FakeHTTP{}
client := NewClient(
ReplaceTripper(http),
)
http.StubResponse(204, bytes.NewBuffer([]byte{}))
r := bytes.NewReader([]byte(`{}`))
err := client.REST("DELETE", "applications/CLIENTID/grant", r, nil)
eq(t, err, nil)
}