From 20e30453d307fa8b8b124159047c900eb27f693f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mislav=20Marohni=C4=87?= Date: Thu, 6 Aug 2020 21:40:32 +0200 Subject: [PATCH] Fix tests that rely on stubbed table printer output --- command/alias.go | 6 ++++-- command/issue.go | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/command/alias.go b/command/alias.go index bc3a9cf15..fc27c1cb0 100644 --- a/command/alias.go +++ b/command/alias.go @@ -6,6 +6,7 @@ import ( "strings" "github.com/MakeNowJust/heredoc" + "github.com/cli/cli/pkg/iostreams" "github.com/cli/cli/utils" "github.com/google/shlex" "github.com/spf13/cobra" @@ -166,8 +167,9 @@ func aliasList(cmd *cobra.Command, args []string) error { return nil } - // TODO: connect to per-command io streams - tp := utils.NewTablePrinter(defaultStreams) + tp := utils.NewTablePrinter(&iostreams.IOStreams{ + Out: cmd.OutOrStdout(), + }) aliasMap := aliasCfg.All() keys := []string{} diff --git a/command/issue.go b/command/issue.go index 02c5ba776..41dd30b7f 100644 --- a/command/issue.go +++ b/command/issue.go @@ -14,6 +14,7 @@ import ( "github.com/cli/cli/pkg/cmd/pr/shared" "github.com/cli/cli/pkg/cmdutil" "github.com/cli/cli/pkg/githubtemplate" + "github.com/cli/cli/pkg/iostreams" "github.com/cli/cli/pkg/text" "github.com/cli/cli/utils" "github.com/spf13/cobra" @@ -548,8 +549,9 @@ func issueCreate(cmd *cobra.Command, args []string) error { } func printIssues(w io.Writer, prefix string, totalCount int, issues []api.Issue) { - // TODO: accept io streams via argument - table := utils.NewTablePrinter(defaultStreams) + io := &iostreams.IOStreams{Out: w} + io.SetStdoutTTY(utils.IsTerminal(w)) + table := utils.NewTablePrinter(io) for _, issue := range issues { issueNum := strconv.Itoa(issue.Number) if table.IsTTY() {