STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(issue edit): resolve race condition in actor assignment

Browse source
This commit is contained in:
Kynan Ware 2025-05-09 23:26:06 -06:00
parent e0afc91fef
commit 218152f7c5
1 changed files with 14 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

30
pkg/cmd/pr/shared/editable_http.go
View file

@ -61,19 +61,13 @@ func UpdateIssue(httpClient *http.Client, repo ghrepo.Interface, id string, isPR
// updateIssue mutation does not support Actors so assignment needs to
// be in a separate request when our assignees are Actors.
if options.Assignees.Edited && options.Assignees.ActorAssignees {
apiClient := api.NewClientFromHTTP(httpClient)
assigneeIds, err := options.AssigneeIds(apiClient, repo)
if err != nil {
return err
}
// Disable the edited flag for assignees so that it doesn't
// trigger a second update in the replaceIssueFields function.
// It's important that this is done AFTER the call to
// options.AssigneeIds() above because otherwise that just exits.
options.Assignees.Edited = false
wg.Go(func() error {
apiClient := api.NewClientFromHTTP(httpClient)
assigneeIds, err := options.AssigneeIds(apiClient, repo)
if err != nil {
return err
}
return replaceActorAssigneesForEditable(apiClient, repo, id, assigneeIds)
})
}
@ -115,16 +109,20 @@ func replaceActorAssigneesForEditable(apiClient *api.Client, repo ghrepo.Interfa
func replaceIssueFields(httpClient *http.Client, repo ghrepo.Interface, id string, isPR bool, options Editable) error {
apiClient := api.NewClientFromHTTP(httpClient)
assigneeIds, err := options.AssigneeIds(apiClient, repo)
if err != nil {
return err
}
projectIds, err := options.ProjectIds()
if err != nil {
return err
}
var assigneeIds *[]string
if !options.Assignees.ActorAssignees {
assigneeIds, err = options.AssigneeIds(apiClient, repo)
if err != nil {
return err
}
}
milestoneId, err := options.MilestoneId()
if err != nil {
return err