From 2248565839cd469bea56ecb41b88108d13455669 Mon Sep 17 00:00:00 2001 From: vilmibm Date: Wed, 9 Dec 2020 17:31:34 -0800 Subject: [PATCH] print success messages --- pkg/cmd/secret/remove/remove.go | 5 +++++ pkg/cmd/secret/secret.go | 1 - pkg/cmd/secret/set/set.go | 5 +++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/secret/remove/remove.go b/pkg/cmd/secret/remove/remove.go index 57057f9fa..0c061d6c3 100644 --- a/pkg/cmd/secret/remove/remove.go +++ b/pkg/cmd/secret/remove/remove.go @@ -89,5 +89,10 @@ func removeRun(opts *RemoveOptions) error { return fmt.Errorf("failed to delete secret %s: %w", opts.SecretName, err) } + if opts.IO.IsStdoutTTY() { + cs := opts.IO.ColorScheme() + fmt.Fprintf(opts.IO.Out, "%s Removed secret %s\n", cs.SuccessIcon(), opts.SecretName) + } + return nil } diff --git a/pkg/cmd/secret/secret.go b/pkg/cmd/secret/secret.go index 2801d7c2b..e8b82a41d 100644 --- a/pkg/cmd/secret/secret.go +++ b/pkg/cmd/secret/secret.go @@ -23,7 +23,6 @@ func NewCmdSecret(f *cmdutil.Factory) *cobra.Command { cmdutil.EnableRepoOverride(cmd, f) cmd.AddCommand(cmdList.NewCmdList(f, nil)) - // TODO add success messages to these: cmd.AddCommand(cmdSet.NewCmdSet(f, nil)) cmd.AddCommand(cmdRemove.NewCmdRemove(f, nil)) diff --git a/pkg/cmd/secret/set/set.go b/pkg/cmd/secret/set/set.go index 458b36697..610e85319 100644 --- a/pkg/cmd/secret/set/set.go +++ b/pkg/cmd/secret/set/set.go @@ -163,6 +163,11 @@ func setRun(opts *SetOptions) error { return fmt.Errorf("failed to set secret: %w", err) } + if opts.IO.IsStdoutTTY() { + cs := opts.IO.ColorScheme() + fmt.Fprintf(opts.IO.Out, "%s Set secret %s\n", cs.SuccessIcon(), opts.SecretName) + } + return nil }