From 229216e8308e51359f779f3798103dd3734870a4 Mon Sep 17 00:00:00 2001 From: Kynan Ware <47394200+BagToad@users.noreply.github.com> Date: Wed, 26 Mar 2025 15:29:20 -0600 Subject: [PATCH] doc(run shared): clarify 404 handling --- pkg/cmd/run/shared/shared.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/cmd/run/shared/shared.go b/pkg/cmd/run/shared/shared.go index 248b5c5a0..ce909fd77 100644 --- a/pkg/cmd/run/shared/shared.go +++ b/pkg/cmd/run/shared/shared.go @@ -452,6 +452,8 @@ func preloadWorkflowNames(client *api.Client, repo ghrepo.Interface, runs []Run) // look it up directly without receiving a 404, but it is nonetheless // in the workflow run list. To handle this, we set the workflow name // to an empty string. + // Deciding to put this here instead of in GetWorkflow to allow + // the caller to decide what a 404 means. if httpErr, ok := err.(api.HTTPError); ok && httpErr.StatusCode == 404 { workflowMap[run.WorkflowID] = "" continue