From 4a5ed8157734460b75cdb279e7bebffcb0f666b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mislav=20Marohni=C4=87?= Date: Tue, 19 Nov 2019 09:01:18 +0100 Subject: [PATCH] Fix injecting version information into build from git This was a typo. Note that Makefile is only used for building a development version after cloning from git; the tagged release process uses `.goreleaser.yml` and skips the Makefile. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 120d44cad..0aa490445 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ BUILD_FILES = $(shell go list -f '{{range .GoFiles}}{{$$.Dir}}/{{.}}\ {{end}}' ./...) -GH_VERSION = $(shell go describe --tags 2>/dev/null || git rev-parse --short HEAD) +GH_VERSION = $(shell git describe --tags 2>/dev/null || git rev-parse --short HEAD) LDFLAGS := -X github.com/github/gh-cli/command.Version=$(GH_VERSION) $(LDFLAGS) LDFLAGS := -X github.com/github/gh-cli/command.BuildDate=$(shell date +%Y-%m-%d) $(LDFLAGS) ifdef GH_OAUTH_CLIENT_SECRET