From 27262ff5aef4eb9a84f814f22a7d03d9e874a09c Mon Sep 17 00:00:00 2001
From: paulober <44974737+paulober@users.noreply.github.com>
Date: Fri, 24 May 2024 16:15:04 +0200
Subject: [PATCH] Added native min os version blocking

Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
---
 build/macOS/distribution.xml | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/build/macOS/distribution.xml b/build/macOS/distribution.xml
index 773321da3..dc93628f8 100644
--- a/build/macOS/distribution.xml
+++ b/build/macOS/distribution.xml
@@ -7,15 +7,20 @@
     <installation-check script="installCheck();"/>
     <script>
     function installCheck() {
-      if (!(system.compareVersions(system.version.ProductVersion, '12') &gt;= 0)) {
-        my.result.title = 'Unable to install';
-        my.result.message = 'GitHub CLI requires macOS 12 or later.';
-        my.result.type = 'Fatal';
-        return false;
-      }
-      return true;
+        // this check is redundant, but it produces a user friendly error message
+        // compared to a disabled install button caused by allowed-os-versions
+        if (!(system.compareVersions(system.version.ProductVersion, '12') &gt;= 0)) {
+            my.result.title = 'Unable to install';
+            my.result.message = 'GitHub CLI requires macOS 12 or later.';
+            my.result.type = 'Fatal';
+            return false;
+        }
+        return true;
     }
     </script>
+    <allowed-os-versions>
+        <os-version min="12.0" />
+    </allowed-os-versions>
 
     <choices-outline>
         <line choice="gh-cli"/>