From 28dd73ffdf1d5defab21e4b46d21a60b58fbc28c Mon Sep 17 00:00:00 2001 From: Jason Lunz Date: Mon, 20 Dec 2021 11:52:39 -0700 Subject: [PATCH] always pass a non-nil logger to openSSHSession --- pkg/cmd/codespace/ssh.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/cmd/codespace/ssh.go b/pkg/cmd/codespace/ssh.go index cce05f131..ce7e7be1d 100644 --- a/pkg/cmd/codespace/ssh.go +++ b/pkg/cmd/codespace/ssh.go @@ -219,7 +219,7 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts configOptions, execut } }() - session, err := a.openSSHSession(ctx, cs, nil) + session, err := a.openSSHSession(ctx, cs, noopLogger()) if err != nil { result.err = fmt.Errorf("error connecting to codespace: %w", err) return @@ -299,10 +299,6 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts configOptions, execut } func (a *App) openSSHSession(ctx context.Context, codespace *api.Codespace, liveshareLogger *log.Logger) (*liveshare.Session, error) { - if liveshareLogger == nil { - liveshareLogger = noopLogger() - } - session, err := codespaces.ConnectToLiveshare(ctx, a, liveshareLogger, a.apiClient, codespace) if err != nil { return nil, fmt.Errorf("error connecting to codespace: %w", err)