From 29a94ab9b1e49e5e1c5b20a8d5820b1decae78af Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Mon, 14 Jul 2025 08:43:15 -0400 Subject: [PATCH] Reformat non-documentation hostnames Outside of the hostnames previously fixed, I talked with @williammartin about what to do with the remaining references and the concern about the mixed format. One suggestion for the error / test use case was to remove the extraneous text all together. --- acceptance/testdata/repo/repo-rename-transfer-ownership.txtar | 4 ++-- pkg/cmd/auth/login/login.go | 2 +- pkg/cmd/repo/rename/rename.go | 2 +- pkg/cmd/repo/rename/rename_test.go | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/acceptance/testdata/repo/repo-rename-transfer-ownership.txtar b/acceptance/testdata/repo/repo-rename-transfer-ownership.txtar index 754a609d7..5075a20a2 100644 --- a/acceptance/testdata/repo/repo-rename-transfer-ownership.txtar +++ b/acceptance/testdata/repo/repo-rename-transfer-ownership.txtar @@ -3,7 +3,7 @@ exec gh repo create $ORG/$SCRIPT_NAME-$RANDOM_STRING --add-readme --private # Attempt to rename the repo with a slash in the name ! exec gh repo rename $ORG/new-name --repo=$ORG/$SCRIPT_NAME-$RANDOM_STRING --yes -stderr 'New repository name cannot contain \''/\'' character - to transfer a repository to a new owner, you must follow additional steps on . For more information on transferring repository ownership, see .' +stderr 'New repository name cannot contain \''/\'' character - to transfer a repository to a new owner, see .' # Defer repo deletion -defer gh repo delete $ORG/$SCRIPT_NAME-$RANDOM_STRING --yes \ No newline at end of file +defer gh repo delete $ORG/$SCRIPT_NAME-$RANDOM_STRING --yes diff --git a/pkg/cmd/auth/login/login.go b/pkg/cmd/auth/login/login.go index 40b2fb382..89410e6a1 100644 --- a/pkg/cmd/auth/login/login.go +++ b/pkg/cmd/auth/login/login.go @@ -95,7 +95,7 @@ func NewCmdLogin(f *cmdutil.Factory, runF func(*LoginOptions) error) *cobra.Comm # Start interactive setup $ gh auth login - # Authenticate against by reading the token from a file + # Authenticate against github.com by reading the token from a file $ gh auth login --with-token < mytoken.txt # Authenticate with specific host diff --git a/pkg/cmd/repo/rename/rename.go b/pkg/cmd/repo/rename/rename.go index 30b573554..7a0c93da2 100644 --- a/pkg/cmd/repo/rename/rename.go +++ b/pkg/cmd/repo/rename/rename.go @@ -126,7 +126,7 @@ func renameRun(opts *RenameOptions) error { } if strings.Contains(newRepoName, "/") { - return fmt.Errorf("New repository name cannot contain '/' character - to transfer a repository to a new owner, you must follow additional steps on . For more information on transferring repository ownership, see .") + return fmt.Errorf("New repository name cannot contain '/' character - to transfer a repository to a new owner, see .") } if opts.DoConfirm { diff --git a/pkg/cmd/repo/rename/rename_test.go b/pkg/cmd/repo/rename/rename_test.go index d6aa2993f..e68530be0 100644 --- a/pkg/cmd/repo/rename/rename_test.go +++ b/pkg/cmd/repo/rename/rename_test.go @@ -227,7 +227,7 @@ func TestRenameRun(t *testing.T) { newRepoSelector: "org/new-name", }, wantErr: true, - errMsg: "New repository name cannot contain '/' character - to transfer a repository to a new owner, you must follow additional steps on . For more information on transferring repository ownership, see .", + errMsg: "New repository name cannot contain '/' character - to transfer a repository to a new owner, see .", }, }