fix: address round 2 code review findings

- Fix PR edit regression: gate Type and Parent behind Allowed bool
  in FieldsToEditSurvey, matching the Reviewers.Allowed pattern.
  Only issue edit sets Allowed=true; PR edit won't show these fields.
- Add missing RemoveBlocking assertion in flag parsing tests
- Quote issue type names containing spaces in search queries
  (type:"Bug Report" instead of type:Bug Report)
- Remove duplicate TODO comment in view.go
- Avoid double RepoIssueTypes API call in interactive create:
  cache the resolved ID from the picker, skip re-resolution
- Rename applyIssueTypes → applyIssueType (singular)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Kynan Ware 2026-03-29 17:42:54 -06:00
parent b6f29b0376
commit 2a72a59f76
5 changed files with 34 additions and 11 deletions

View file

@ -424,6 +424,7 @@ func TestNewCmdEdit(t *testing.T) {
assert.Equal(t, tt.output.AddBlockedBy, gotOpts.AddBlockedBy)
assert.Equal(t, tt.output.RemoveBlockedBy, gotOpts.RemoveBlockedBy)
assert.Equal(t, tt.output.AddBlocking, gotOpts.AddBlocking)
assert.Equal(t, tt.output.RemoveBlocking, gotOpts.RemoveBlocking)
if tt.expectedBaseRepo != nil {
baseRepo, err := gotOpts.BaseRepo()
require.NoError(t, err)