STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #13363 from cli/wm-accessible-telemetry

Browse source 
Record accessibility feature state in telemetry
This commit is contained in:
William Martin 2026-05-07 18:48:28 +02:00 • committed by GitHub
commit 2bc88628dc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 31 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
acceptance/testdata/telemetry/accessibility-dimensions-disabled.txtar vendored Normal file
View file

@ -0,0 +1,9 @@
# Telemetry log mode records accessibility features as disabled by default
env GH_TELEMETRY=log
env GH_TELEMETRY_SAMPLE_RATE=100
exec gh version
stderr '"accessible_colors": "false"'
stderr '"accessible_prompter": "false"'
stderr '"color_labels": "false"'
stderr '"spinner_disabled": "false"'

13
acceptance/testdata/telemetry/accessibility-dimensions.txtar vendored Normal file
View file

@ -0,0 +1,13 @@
# Telemetry log mode records accessibility feature state as dimensions
env GH_TELEMETRY=log
env GH_TELEMETRY_SAMPLE_RATE=100
env GH_ACCESSIBLE_COLORS=true
env GH_ACCESSIBLE_PROMPTER=true
env GH_COLOR_LABELS=true
env GH_SPINNER_DISABLED=true
exec gh version
stderr '"accessible_colors": "true"'
stderr '"accessible_prompter": "true"'
stderr '"color_labels": "true"'
stderr '"spinner_disabled": "true"'

14
internal/ghcmd/cmd.go
View file

@ -71,11 +71,15 @@ func Main() exitCode {
ghExecutablePath := executablePath("gh")
additionalCommonDimensions := ghtelemetry.Dimensions{
"version": strings.TrimPrefix(buildVersion, "v"),
"is_tty": strconv.FormatBool(ioStreams.IsStdoutTTY()),
"agent": string(agents.Detect()),
"ci": strconv.FormatBool(ci.IsCI()),
"github_actions": strconv.FormatBool(ci.IsGitHubActions()),
"version": strings.TrimPrefix(buildVersion, "v"),
"is_tty": strconv.FormatBool(ioStreams.IsStdoutTTY()),
"agent": string(agents.Detect()),
"ci": strconv.FormatBool(ci.IsCI()),
"github_actions": strconv.FormatBool(ci.IsGitHubActions()),
"accessible_colors": strconv.FormatBool(ioStreams.AccessibleColorsEnabled()),
"accessible_prompter": strconv.FormatBool(ioStreams.AccessiblePrompterEnabled()),
"color_labels": strconv.FormatBool(ioStreams.ColorLabels()),
"spinner_disabled": strconv.FormatBool(ioStreams.GetSpinnerDisabled()),
}
var telemetryService ghtelemetry.Service