STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

return err, don"t fatal

Browse source
This commit is contained in:
Alan Donovan 2021-09-09 16:37:26 -04:00
parent ee44ecc944
commit 2cbe120774
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
cmd/ghcs/main.go
View file

@ -42,8 +42,7 @@ token to access the GitHub API with.`,
if os.Getenv("GITHUB_TOKEN") == "" { if os.Getenv("GITHUB_TOKEN") == "" {
return tokenError return tokenError
} }
initLightstep(lightstep) return initLightstep(lightstep)
return nil
}, },
} }
@ -64,9 +63,9 @@ func explainError(w io.Writer, err error) {
// initLightstep parses the --lightstep=service:token@host:port flag and // initLightstep parses the --lightstep=service:token@host:port flag and
// enables tracing if non-empty. // enables tracing if non-empty.
func initLightstep(config string) { func initLightstep(config string) error {
if config == "" { if config == "" {
return return nil
} }
cut := func(s, sep string) (pre, post string) { cut := func(s, sep string) (pre, post string) {
@ -82,7 +81,7 @@ func initLightstep(config string) {
host, port := cut(hostPort, ":") host, port := cut(hostPort, ":")
portI, err := strconv.Atoi(port) portI, err := strconv.Atoi(port)
if err != nil { if err != nil {
log.Fatalf("invalid Lightstep configuration: %s", config) return fmt.Errorf("invalid Lightstep configuration: %s", config)
} }
opentracing.SetGlobalTracer(lightstep.NewTracer(lightstep.Options{ opentracing.SetGlobalTracer(lightstep.NewTracer(lightstep.Options{
@ -106,4 +105,6 @@ func initLightstep(config string) {
log.Printf("[trace] %s", ev) log.Printf("[trace] %s", ev)
} }
}) })
return nil
} }