STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pr feedback

Browse source 
Signed-off-by: Meredith Lancaster <malancas@github.com>
This commit is contained in:
Meredith Lancaster 2024-11-21 09:11:18 -07:00
parent 28565dc1f8
commit 2d41225dd5
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
pkg/cmd/attestation/verification/extensions.go
View file

@ -18,8 +18,7 @@ func VerifyCertExtensions(results []*AttestationProcessingResult, ec Enforcement
return nil, errors.New("no attestations processing results")
}
verified := make([]*AttestationProcessingResult, len(results))
var verifyCount int
verified := make([]*AttestationProcessingResult, 0, len(results))
var lastErr error
for _, attestation := range results {
if err := verifyCertExtensions(*attestation.VerificationResult.Signature.Certificate, ec.Certificate); err != nil {
@ -28,20 +27,16 @@ func VerifyCertExtensions(results []*AttestationProcessingResult, ec Enforcement
continue
}
// otherwise, add the result to the results slice and increment verifyCount
verified[verifyCount] = attestation
verifyCount++
verified = append(verified, attestation)
}
// if we have exited the for loop without verifying any attestations,
// return the last error found
if verifyCount == 0 {
if len(verified) == 0 {
return nil, lastErr
}
// truncate the verified slice to only include verified attestations
verified = verified[:verifyCount]
return verified, nil
}
func verifyCertExtensions(given, expected certificate.Summary) error {