STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hide potentially long query strings when printing urls

Browse source
This commit is contained in:
vilmibm 2020-01-16 14:18:40 -06:00
parent beeb35e7e2
commit 31001877bd
2 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
command/issue.go
View file

@ -353,7 +353,11 @@ func issueCreate(cmd *cobra.Command, args []string) error {
url.QueryEscape(body),
)
// TODO could exceed max url length for explorer
fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s in your browser.\n", openURL)
url, err := url.Parse(openURL)
if err != nil {
return err
}
fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s%s in your browser.\n", url.Host, url.Path)
return utils.OpenInBrowser(openURL)
} else if action == SubmitAction {
params := map[string]interface{}{

8
command/pr_create.go
View file

@ -148,11 +148,13 @@ func prCreate(cmd *cobra.Command, _ []string) error {
url.QueryEscape(title),
url.QueryEscape(body),
)
// TODO maybe do something about -d being discarded when previewing
// TODO could exceed max url length for explorer
fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s in your browser.\n", openURL)
url, err := url.Parse(openURL)
if err != nil {
return err
}
fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s%s in your browser.\n", url.Host, url.Path)
return utils.OpenInBrowser(openURL)
} else {
panic("Unreachable state")
}