From 40a0b0d51122191d9b8be620cf0c75a36288949a Mon Sep 17 00:00:00 2001 From: Pushpamk Date: Thu, 8 Oct 2020 00:55:44 +0530 Subject: [PATCH 1/3] updated new github doc. link --- api/queries_issue.go | 2 +- pkg/cmd/pr/view/view.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/api/queries_issue.go b/api/queries_issue.go index 6ef431ed4..3804fea2a 100644 --- a/api/queries_issue.go +++ b/api/queries_issue.go @@ -23,7 +23,7 @@ type IssuesAndTotalCount struct { TotalCount int } -// Ref. https://developer.github.com/v4/object/issue/ +// Ref. https://docs.github.com/v4/object/issue type Issue struct { ID string Number int diff --git a/pkg/cmd/pr/view/view.go b/pkg/cmd/pr/view/view.go index 33a75b34d..82f5d0ef0 100644 --- a/pkg/cmd/pr/view/view.go +++ b/pkg/cmd/pr/view/view.go @@ -191,7 +191,7 @@ func printHumanPrPreview(io *iostreams.IOStreams, pr *api.PullRequest) error { return nil } -// Ref. https://developer.github.com/v4/enum/pullrequestreviewstate/ +// Ref. https://docs.github.com/v4/enum/pullrequestreviewstate/ const ( requestedReviewState = "REQUESTED" // This is our own state for review request approvedReviewState = "APPROVED" @@ -250,7 +250,7 @@ func prReviewerList(pr api.PullRequest) string { return reviewerList } -// Ref. https://developer.github.com/v4/union/requestedreviewer/ +// Ref. https://docs.github.com/v4/enum/pullrequestreviewstate/ const teamTypeName = "Team" const ghostName = "ghost" From f8a49ca6245c24deb94ed762bb2aae0c73b66d5f Mon Sep 17 00:00:00 2001 From: Pushpamk Date: Thu, 8 Oct 2020 16:04:28 +0530 Subject: [PATCH 2/3] updated reference comment --- api/queries_issue.go | 2 +- pkg/cmd/pr/view/view.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/api/queries_issue.go b/api/queries_issue.go index 3804fea2a..b04ac3245 100644 --- a/api/queries_issue.go +++ b/api/queries_issue.go @@ -23,7 +23,7 @@ type IssuesAndTotalCount struct { TotalCount int } -// Ref. https://docs.github.com/v4/object/issue +// Ref. Please see Github GraphQL object issue reference page type Issue struct { ID string Number int diff --git a/pkg/cmd/pr/view/view.go b/pkg/cmd/pr/view/view.go index 82f5d0ef0..5a437e154 100644 --- a/pkg/cmd/pr/view/view.go +++ b/pkg/cmd/pr/view/view.go @@ -191,7 +191,7 @@ func printHumanPrPreview(io *iostreams.IOStreams, pr *api.PullRequest) error { return nil } -// Ref. https://docs.github.com/v4/enum/pullrequestreviewstate/ +// Ref. Please see Github GraphQL PullRequestReviewState reference page const ( requestedReviewState = "REQUESTED" // This is our own state for review request approvedReviewState = "APPROVED" @@ -250,7 +250,7 @@ func prReviewerList(pr api.PullRequest) string { return reviewerList } -// Ref. https://docs.github.com/v4/enum/pullrequestreviewstate/ +// Ref. Please see Github GraphQL PullRequestReviewState reference page const teamTypeName = "Team" const ghostName = "ghost" From 581783176a9c741c6b4f853a24a7a437629dbca2 Mon Sep 17 00:00:00 2001 From: Pushpamk Date: Thu, 8 Oct 2020 20:34:10 +0530 Subject: [PATCH 3/3] deleted comment --- api/queries_issue.go | 1 - pkg/cmd/pr/view/view.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/api/queries_issue.go b/api/queries_issue.go index b04ac3245..d607901a3 100644 --- a/api/queries_issue.go +++ b/api/queries_issue.go @@ -23,7 +23,6 @@ type IssuesAndTotalCount struct { TotalCount int } -// Ref. Please see Github GraphQL object issue reference page type Issue struct { ID string Number int diff --git a/pkg/cmd/pr/view/view.go b/pkg/cmd/pr/view/view.go index 5a437e154..4476a84c0 100644 --- a/pkg/cmd/pr/view/view.go +++ b/pkg/cmd/pr/view/view.go @@ -191,7 +191,6 @@ func printHumanPrPreview(io *iostreams.IOStreams, pr *api.PullRequest) error { return nil } -// Ref. Please see Github GraphQL PullRequestReviewState reference page const ( requestedReviewState = "REQUESTED" // This is our own state for review request approvedReviewState = "APPROVED" @@ -250,7 +249,6 @@ func prReviewerList(pr api.PullRequest) string { return reviewerList } -// Ref. Please see Github GraphQL PullRequestReviewState reference page const teamTypeName = "Team" const ghostName = "ghost"