From 346bd8c0020f95aaa3df051939b9d1e874a76dd7 Mon Sep 17 00:00:00 2001 From: Kynan Ware <47394200+BagToad@users.noreply.github.com> Date: Mon, 26 Jan 2026 11:33:11 -0700 Subject: [PATCH] Simplify suggested assignable actors Simplifies SuggestedAssignableActors by no longer including the viewer in the returned actors list when the query is blank. Removes related logic and variables for viewer handling. --- api/queries_pr.go | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/api/queries_pr.go b/api/queries_pr.go index 6f0b65d67..11502071d 100644 --- a/api/queries_pr.go +++ b/api/queries_pr.go @@ -780,29 +780,16 @@ func SuggestedAssignableActors(client *Client, repo ghrepo.Interface, assignable nodes = result.Node.Issue.SuggestedActors.Nodes } - actors := make([]AssignableActor, 0, len(nodes)+1) // +1 in case we add viewer - viewer := result.Viewer - viewerLogin := viewer.Login - viewerIncluded := false + actors := make([]AssignableActor, 0, len(nodes)) for _, n := range nodes { if n.TypeName == "User" && n.User.Login != "" { actors = append(actors, AssignableUser{id: n.User.ID, login: n.User.Login, name: n.User.Name}) - if query == "" && viewerLogin != "" && n.User.Login == viewerLogin { - viewerIncluded = true - } } else if n.TypeName == "Bot" && n.Bot.Login != "" { actors = append(actors, AssignableBot{id: n.Bot.ID, login: n.Bot.Login}) - if query == "" && viewerLogin != "" && n.Bot.Login == viewerLogin { - viewerIncluded = true - } } } - // When query is blank, append viewer if not already present. - if query == "" && viewerLogin != "" && !viewerIncluded { - actors = append(actors, AssignableUser{id: viewer.ID, login: viewer.Login, name: viewer.Name}) - } return actors, nil }