STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Match return style

Browse source
This commit is contained in:
JP Ungaretti 2023-03-07 19:05:49 +00:00
parent c347737ace
commit 39a1dc90af
3 changed files with 25 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

12
pkg/cmd/codespace/jupyter.go
View file

@ -46,15 +46,19 @@ func (a *App) Jupyter(ctx context.Context, selector *CodespaceSelector) (err err
defer safeClose(session, &err)
serverPort, serverUrl := 0, ""
err = a.RunWithProgress("Starting JupyterLab on codespace", func() error {
err = a.RunWithProgress("Starting JupyterLab on codespace", func() (err error) {
invoker, err := rpc.CreateInvoker(ctx, session)
if err != nil {
return err
return
}
err = invoker.Close()
if err != nil {
return
}
defer safeClose(invoker, &err)
serverPort, serverUrl, err = invoker.StartJupyterServer(ctx)
return err
return
})
if err != nil {
return err

12
pkg/cmd/codespace/logs.go
View file

@ -56,15 +56,19 @@ func (a *App) Logs(ctx context.Context, selector *CodespaceSelector, follow bool
defer listen.Close()
remoteSSHServerPort, sshUser := 0, ""
err = a.RunWithProgress("Fetching SSH Details", func() error {
err = a.RunWithProgress("Fetching SSH Details", func() (err error) {
invoker, err := rpc.CreateInvoker(ctx, session)
if err != nil {
return err
return
}
err = invoker.Close()
if err != nil {
return
}
defer safeClose(invoker, &err)
remoteSSHServerPort, sshUser, err = invoker.StartSSHServer(ctx)
return err
return
})
if err != nil {
return fmt.Errorf("error getting ssh server details: %w", err)

14
pkg/cmd/codespace/ssh.go
View file

@ -172,15 +172,19 @@ func (a *App) SSH(ctx context.Context, sshArgs []string, opts sshOptions) (err e
defer safeClose(session, &err)
remoteSSHServerPort, sshUser := 0, ""
err = a.RunWithProgress("Fetching SSH Details", func() error {
err = a.RunWithProgress("Fetching SSH Details", func() (err error) {
invoker, err := rpc.CreateInvoker(ctx, session)
if err != nil {
return err
return
}
err = invoker.Close()
if err != nil {
return
}
defer safeClose(invoker, &err)
remoteSSHServerPort, sshUser, err = invoker.StartSSHServerWithOptions(ctx, startSSHOptions)
return err
return
})
if err != nil {
return fmt.Errorf("error getting ssh server details: %w", err)
@ -476,7 +480,7 @@ func (a *App) printOpenSSHConfig(ctx context.Context, opts sshOptions) (err erro
if opts.selector.codespaceName == "" {
err = a.RunWithProgress("Fetching codespaces", func() (err error) {
csList, err = a.apiClient.ListCodespaces(ctx, api.ListCodespacesOptions{})
return err
return
})
} else {
var codespace *api.Codespace