From 3790262123eb2550c93a142c0c30f97017d23287 Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Thu, 14 Dec 2023 09:50:29 -0500 Subject: [PATCH] Fix issue sourcing signtool for Windows signing Workflow is currently breaking because there are multiple versions of signtool installed on runners. We face a challenge where we either hardcode this to a specific version on the runner or always choose the latest version; this change does the latter. --- script/sign.ps1 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/script/sign.ps1 b/script/sign.ps1 index 3195cbe66..54439c919 100644 --- a/script/sign.ps1 +++ b/script/sign.ps1 @@ -8,4 +8,7 @@ if ($null -ne $env:METADATA_PATH) { exit } -& (Resolve-Path "C:\Program Files (x86)\Windows Kits\10\bin\*\x64\signtool.exe") sign /d "GitHub CLI" /fd sha256 /td sha256 /tr http://timestamp.acs.microsoft.com /v /dlib "$Env:DLIB_PATH" /dmdf "$Env:METADATA_PATH" "$args[0]" +$signtool = Resolve-Path "C:\Program Files (x86)\Windows Kits\10\bin\*\x64\signtool.exe" | Select-Object -Last 1 +Write-Host "Using signtool from $signtool" + +& $signtool sign /d "GitHub CLI" /fd sha256 /td sha256 /tr http://timestamp.acs.microsoft.com /v /dlib "$Env:DLIB_PATH" /dmdf "$Env:METADATA_PATH" "$args[0]"