STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(telemetry): use CREATE_NO_WINDOW to prevent tzutil console flash on Windows

Browse source 
DETACHED_PROCESS leaves the gh send-telemetry child with no console at
all. When the transitive dependency thlib/go-timezone-local invokes
`tzutil /g` to resolve the local IANA timezone, the console-subsystem
tzutil binary allocates a fresh conhost — producing a visible window
flash on every gh invocation, which accumulates as orphan terminals
under terminal configurations that keep windows open on exit.

CREATE_NO_WINDOW gives the child a non-visible console that descendants
inherit, suppressing the flash. CREATE_NEW_PROCESS_GROUP is preserved
so Ctrl+C still does not propagate to the detached telemetry child.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
adehad 2026-05-09 08:35:38 +01:00
parent 3c162a78ef
commit 3d9f22c115
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/telemetry/detach_windows.go
View file

@ -10,7 +10,15 @@ import (
// detachAttrs returns SysProcAttr configured to place the child in its own
// process group so that console signals (Ctrl+C) delivered to the parent's
// group are not forwarded to the child.
// group are not forwarded to the child, and to suppress any console window
// for the child and its descendants.
//
// CREATE_NO_WINDOW is preferred over DETACHED_PROCESS here: DETACHED_PROCESS
// removes the console entirely, which causes any console-subsystem descendant
// (e.g. tzutil.exe invoked transitively to resolve the local IANA timezone)
// to allocate a fresh conhost window, producing a visible flash on every gh
// invocation. CREATE_NO_WINDOW gives the child a non-visible console that
// descendants can inherit, avoiding the flash.
func detachAttrs() *syscall.SysProcAttr {
return &syscall.SysProcAttr{CreationFlags: windows.CREATE_NEW_PROCESS_GROUP | windows.DETACHED_PROCESS}
return &syscall.SysProcAttr{CreationFlags: windows.CREATE_NEW_PROCESS_GROUP | windows.CREATE_NO_WINDOW}
}