From 3feeb9a826e31cd6afbb884a4deeade37c802364 Mon Sep 17 00:00:00 2001
From: Tyler McGoffin <jtmcg@github.com>
Date: Tue, 14 Jan 2025 11:41:20 -0800
Subject: [PATCH] Add tests for deleteGist

---
 pkg/cmd/gist/delete/delete_test.go | 70 ++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/pkg/cmd/gist/delete/delete_test.go b/pkg/cmd/gist/delete/delete_test.go
index 74c511237..24ca2bb33 100644
--- a/pkg/cmd/gist/delete/delete_test.go
+++ b/pkg/cmd/gist/delete/delete_test.go
@@ -7,6 +7,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/cli/cli/v2/api"
 	"github.com/cli/cli/v2/internal/config"
 	"github.com/cli/cli/v2/internal/gh"
 	"github.com/cli/cli/v2/internal/prompter"
@@ -14,6 +15,7 @@ import (
 	"github.com/cli/cli/v2/pkg/cmdutil"
 	"github.com/cli/cli/v2/pkg/httpmock"
 	"github.com/cli/cli/v2/pkg/iostreams"
+	ghAPI "github.com/cli/go-gh/v2/pkg/api"
 	"github.com/google/shlex"
 	"github.com/stretchr/testify/assert"
 )
@@ -322,3 +324,71 @@ func Test_deleteRun(t *testing.T) {
 		})
 	}
 }
+
+func Test_gistDelete(t *testing.T) {
+	tests := []struct {
+		name      string
+		httpStubs func(*httpmock.Registry)
+		hostname  string
+		gistID    string
+		wantErr   error
+	}{
+		{
+			name: "successful delete",
+			httpStubs: func(reg *httpmock.Registry) {
+				reg.Register(
+					httpmock.REST("DELETE", "gists/1234"),
+					httpmock.StatusStringResponse(204, "{}"),
+				)
+			},
+			hostname: "github.com",
+			gistID:   "1234",
+			wantErr:  nil,
+		},
+		{
+			name: "when an gist is not found, it returns a NotFoundError",
+			httpStubs: func(reg *httpmock.Registry) {
+				reg.Register(
+					httpmock.REST("DELETE", "gists/1234"),
+					httpmock.StatusStringResponse(404, "{}"),
+				)
+			},
+			hostname: "github.com",
+			gistID:   "1234",
+			wantErr:  shared.NotFoundErr,
+		},
+		{
+			name: "when there is a non-404 error deleting the gist, that error is returned",
+			httpStubs: func(reg *httpmock.Registry) {
+				reg.Register(
+					httpmock.REST("DELETE", "gists/1234"),
+					httpmock.StatusJSONResponse(500, `{"message": "arbitrary error"}`),
+				)
+			},
+			hostname: "github.com",
+			gistID:   "1234",
+			wantErr: api.HTTPError{
+				HTTPError: &ghAPI.HTTPError{
+					StatusCode: 500,
+					Message:    "arbitrary error",
+				},
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			reg := &httpmock.Registry{}
+			tt.httpStubs(reg)
+			client := api.NewClientFromHTTP(&http.Client{Transport: reg})
+
+			err := deleteGist(client, tt.hostname, tt.gistID)
+			if tt.wantErr != nil {
+				assert.ErrorAs(t, err, &tt.wantErr)
+			} else {
+				assert.NoError(t, err)
+			}
+
+		})
+	}
+}