From c5ea30da4789facca19aaeff6efb2acceb88a57b Mon Sep 17 00:00:00 2001 From: Tyler McGoffin Date: Wed, 7 Aug 2024 10:57:02 -0700 Subject: [PATCH 1/2] Add Acceptance Criteria requirement to triage.md for accepted issues To better facilitate community collaboration and to help reduce the amount of information any collaborator needs to peruse in a given issue, clear Acceptance Criteria on accepted issues should be included. This will reduce the amount of back and forth on PRs submitted by ensuring expectations for a given issue are clear --- docs/triage.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/triage.md b/docs/triage.md index ae9b0c15c..327756c8b 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -8,6 +8,8 @@ triage role. The initial expectation is that the person in the role for the week Review and label [open issues missing either the `enhancement`, `bug`, or `docs` label](https://github.com/cli/cli/issues?q=is%3Aopen+is%3Aissue+-label%3Abug%2Cenhancement%2Cdocs+). +Any issue that is accepted to be done as either an `enhancement`, `bug`, or `docs` requires explicit Acceptance Criteria in a comment on the issue before it is triaged. + To be considered triaged, `enhancement` issues require at least one of the following additional labels: - `core`: reserved for the core CLI team From fa06623f9b428f29aeba54c5f45c005e78334b5a Mon Sep 17 00:00:00 2001 From: Tyler McGoffin Date: Wed, 7 Aug 2024 11:46:22 -0700 Subject: [PATCH 2/2] Update docs/triage.md Co-authored-by: Andy Feller --- docs/triage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/triage.md b/docs/triage.md index 327756c8b..d78a81aed 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -8,7 +8,7 @@ triage role. The initial expectation is that the person in the role for the week Review and label [open issues missing either the `enhancement`, `bug`, or `docs` label](https://github.com/cli/cli/issues?q=is%3Aopen+is%3Aissue+-label%3Abug%2Cenhancement%2Cdocs+). -Any issue that is accepted to be done as either an `enhancement`, `bug`, or `docs` requires explicit Acceptance Criteria in a comment on the issue before it is triaged. +Any issue that is accepted to be done as either an `enhancement`, `bug`, or `docs` requires explicit Acceptance Criteria in a comment on the issue before `needs-triage` label is removed. To be considered triaged, `enhancement` issues require at least one of the following additional labels: