STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

update linter checks

Browse source
This commit is contained in:
vilmibm 2022-07-26 16:06:52 -05:00
parent 710212fb3d
commit 40ecb8c188
26 changed files with 187 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

30
pkg/cmd/pr/create/create_test.go
View file

@ -311,12 +311,15 @@ func TestPRCreate_recover(t *testing.T) {
cs.Register(`git status --porcelain`, 0, "")
cs.Register(`git( .+)? log( .+)? origin/master\.\.\.feature`, 0, "")
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use NewAskStubber
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use PrompterMock
as, teardown := prompt.InitAskStubber()
defer teardown()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("Title").AnswerDefault()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("Body").AnswerDefault()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("What's next?").AnswerDefault()
tmpfile, err := os.CreateTemp(t.TempDir(), "testrecover*")
@ -409,10 +412,11 @@ func TestPRCreate(t *testing.T) {
cs.Register(`git show-ref --verify -- HEAD refs/remotes/origin/feature`, 0, "")
cs.Register(`git push --set-upstream origin HEAD:feature`, 0, "")
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use NewAskStubber
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use PrompterMock
ask, cleanupAsk := prompt.InitAskStubber()
defer cleanupAsk()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
ask.StubPrompt("Where should we push the 'feature' branch?").AnswerDefault()
output, err := runCommand(http, nil, "feature", true, `-t "my title" -b "my body"`)
@ -456,10 +460,11 @@ func TestPRCreate_NoMaintainerModify(t *testing.T) {
cs.Register(`git show-ref --verify -- HEAD refs/remotes/origin/feature`, 0, "")
cs.Register(`git push --set-upstream origin HEAD:feature`, 0, "")
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use NewAskStubber
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use PrompterMock
ask, cleanupAsk := prompt.InitAskStubber()
defer cleanupAsk()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
ask.StubPrompt("Where should we push the 'feature' branch?").AnswerDefault()
output, err := runCommand(http, nil, "feature", true, `-t "my title" -b "my body" --no-maintainer-edit`)
@ -508,10 +513,11 @@ func TestPRCreate_createFork(t *testing.T) {
cs.Register(`git remote add -f fork https://github.com/monalisa/REPO.git`, 0, "")
cs.Register(`git push --set-upstream fork HEAD:feature`, 0, "")
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use NewAskStubber
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use PrompterMock
ask, cleanupAsk := prompt.InitAskStubber()
defer cleanupAsk()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
ask.StubPrompt("Where should we push the 'feature' branch?").
AssertOptions([]string{"OWNER/REPO", "Create a fork of OWNER/REPO", "Skip pushing the branch", "Cancel"}).
AnswerWith("Create a fork of OWNER/REPO")
@ -568,7 +574,7 @@ func TestPRCreate_pushedToNonBaseRepo(t *testing.T) {
deadbeef refs/remotes/origin/feature
`)) // determineTrackingBranch
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use NewAskStubber
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use PrompterMock
_, cleanupAsk := prompt.InitAskStubber()
defer cleanupAsk()
@ -610,7 +616,7 @@ func TestPRCreate_pushedToDifferentBranchName(t *testing.T) {
deadbeef refs/remotes/origin/my-feat2
`)) // determineTrackingBranch
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use NewAskStubber
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use PrompterMock
_, cleanupAsk := prompt.InitAskStubber()
defer cleanupAsk()
@ -656,10 +662,13 @@ func TestPRCreate_nonLegacyTemplate(t *testing.T) {
as := prompt.NewAskStubber(t)
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("Choose a template").
AssertOptions([]string{"template1", "template2", "Open a blank pull request"}).
AnswerWith("template1")
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("Body").AnswerDefault()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("What's next?").
AssertOptions([]string{"Submit", "Submit as draft", "Continue in browser", "Add metadata", "Cancel"}).
AnswerDefault()
@ -801,10 +810,11 @@ func TestPRCreate_web(t *testing.T) {
cs.Register(`git( .+)? log( .+)? origin/master\.\.\.feature`, 0, "")
cs.Register(`git push --set-upstream origin HEAD:feature`, 0, "")
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use NewAskStubber
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use PrompterMock
ask, cleanupAsk := prompt.InitAskStubber()
defer cleanupAsk()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
ask.StubPrompt("Where should we push the 'feature' branch?").
AssertOptions([]string{"OWNER/REPO", "Skip pushing the branch", "Cancel"}).
AnswerDefault()
@ -876,10 +886,11 @@ func TestPRCreate_webProject(t *testing.T) {
cs.Register(`git( .+)? log( .+)? origin/master\.\.\.feature`, 0, "")
cs.Register(`git push --set-upstream origin HEAD:feature`, 0, "")
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use NewAskStubber
//nolint:staticcheck // SA1019: prompt.InitAskStubber is deprecated: use PrompterMock
ask, cleanupAsk := prompt.InitAskStubber()
defer cleanupAsk()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
ask.StubPrompt("Where should we push the 'feature' branch?").AnswerDefault()
output, err := runCommand(http, nil, "feature", true, `--web -p Triage`)
@ -918,8 +929,11 @@ func TestPRCreate_draft(t *testing.T) {
as := prompt.NewAskStubber(t)
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("Choose a template").AnswerDefault()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("Body").AnswerDefault()
//nolint:staticcheck // SA1019: as.StubPrompt is deprecated: use PrompterMock
as.StubPrompt("What's next?").
AssertOptions([]string{"Submit", "Submit as draft", "Continue in browser", "Add metadata", "Cancel"}).
AnswerWith("Submit as draft")