From 49f1bd88004d02f73e8a7d468673decca6904be4 Mon Sep 17 00:00:00 2001 From: Kynan Ware <47394200+BagToad@users.noreply.github.com> Date: Thu, 5 Mar 2026 10:58:23 -0700 Subject: [PATCH] Add TODO requestReviewsByLoginCleanup on GHES ID-based reviewer path Mark the GHES ID-resolution branch in AddMetadataToIssueParams for cleanup once GHES supports requestReviewsByLogin. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- pkg/cmd/pr/shared/params.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/pr/shared/params.go b/pkg/cmd/pr/shared/params.go index 90e1e6f89..d5c168e5f 100644 --- a/pkg/cmd/pr/shared/params.go +++ b/pkg/cmd/pr/shared/params.go @@ -130,8 +130,10 @@ func AddMetadataToIssueParams(client *api.Client, baseRepo ghrepo.Interface, par } } + // TODO requestReviewsByLoginCleanup // When ActorReviewers is true (github.com), pass logins directly for use with - // RequestReviewsByLogin mutation. Otherwise, resolve to IDs for GHES compatibility. + // RequestReviewsByLogin mutation. The ID-based else branch can be removed once + // GHES supports requestReviewsByLogin. if tb.ActorReviewers { params["userReviewerLogins"] = userReviewers if len(botReviewers) > 0 {