STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Other changes

Browse source 
- Changed function to method
- Moved additional common options to method
- Remove redundant documentation
    - Cobra sets documentation in the Command struct.
This commit is contained in:
chemotaxis 2022-03-30 03:09:50 -04:00
parent 72a92fa09d
commit 4b226b1bf8
1 changed files with 8 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

23
pkg/cmd/issue/lock/lock.go
View file

@ -53,7 +53,12 @@ type LockOptions struct {
IssueNumber string
}
func setCommonOptions(f *cmdutil.Factory, cmd *cobra.Command, opts *LockOptions, args []string) {
func (opts *LockOptions) setCommonOptions(f *cmdutil.Factory, cmd *cobra.Command, args []string) {
opts.IO = f.IOStreams
opts.HttpClient = f.HttpClient
opts.Config = f.Config
// support `-R, --repo` override
opts.BaseRepo = f.BaseRepo
@ -63,15 +68,9 @@ func setCommonOptions(f *cmdutil.Factory, cmd *cobra.Command, opts *LockOptions,
opts.IssueNumber = args[0]
}
// NewCmdLock will lock the conversation for an issue or pull request
func NewCmdLock(f *cmdutil.Factory, runF func(*LockOptions) error) *cobra.Command {
// TODO: Currently doesn't work. Besides some minor changes, code is copy
// and pasted from NewCmdReopen().
opts := &LockOptions{
IO: f.IOStreams,
HttpClient: f.HttpClient,
Config: f.Config,
PadlockState: Lock,
}
@ -92,7 +91,7 @@ func NewCmdLock(f *cmdutil.Factory, runF func(*LockOptions) error) *cobra.Comman
opts.Reason = jsonReason
}
setCommonOptions(f, cmd, opts, args)
opts.setCommonOptions(f, cmd, args)
if runF != nil {
return runF(opts)
@ -107,15 +106,9 @@ func NewCmdLock(f *cmdutil.Factory, runF func(*LockOptions) error) *cobra.Comman
return cmd
}
// NewCmdUnlock will unlock the conversation for an issue or pull request
func NewCmdUnlock(f *cmdutil.Factory, runF func(*LockOptions) error) *cobra.Command {
// TODO: Currently doesn't work. Besides some minor changes, code is copy
// and pasted from NewCmdReopen().
opts := &LockOptions{
IO: f.IOStreams,
HttpClient: f.HttpClient,
Config: f.Config,
PadlockState: Unlock,
}
@ -125,7 +118,7 @@ func NewCmdUnlock(f *cmdutil.Factory, runF func(*LockOptions) error) *cobra.Comm
Args: cobra.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
setCommonOptions(f, cmd, opts, args)
opts.setCommonOptions(f, cmd, args)
if runF != nil {
return runF(opts)