STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ensure that tests for command factory never read from user's config

Browse source 
If these tests are going to exerise `factory.New()`, the config getter
should always be overriden since the default config getter reads from
`~/.config/gh` and thus makes tests dependent on the user's environment.
This commit is contained in:
Mislav Marohnić 2021-06-17 17:59:34 +02:00
parent dd3aac7f52
commit 4b2cded1f8
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
pkg/cmd/factory/default_test.go
View file

@ -333,8 +333,10 @@ func Test_ioStreams_pager(t *testing.T) {
}
}
f := New("1")
if tt.config != nil {
f.Config = func() (config.Config, error) {
f.Config = func() (config.Config, error) {
if tt.config == nil {
return config.NewBlankConfig(), nil
} else {
return tt.config, nil
}
}
@ -363,8 +365,10 @@ func Test_ioStreams_prompt(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
f := New("1")
if tt.config != nil {
f.Config = func() (config.Config, error) {
f.Config = func() (config.Config, error) {
if tt.config == nil {
return config.NewBlankConfig(), nil
} else {
return tt.config, nil
}
}