From 4debbb17cd40aaa6eb89e29c5ef7fd1e09ec2b6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mislav=20Marohni=C4=87?= Date: Fri, 11 Jun 2021 14:32:08 +0200 Subject: [PATCH] Further separate out test cases --- pkg/cmd/factory/http_test.go | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/pkg/cmd/factory/http_test.go b/pkg/cmd/factory/http_test.go index 296468f9a..6172d846c 100644 --- a/pkg/cmd/factory/http_test.go +++ b/pkg/cmd/factory/http_test.go @@ -46,37 +46,53 @@ func TestNewHTTPClient(t *testing.T) { { name: "github.com no Accept header", args: args{ - config: tinyConfig{"example.com:oauth_token": "MYTOKEN"}, + config: tinyConfig{"github.com:oauth_token": "MYTOKEN"}, appVersion: "v1.2.3", setAccept: false, }, host: "github.com", wantHeader: map[string]string{ - "authorization": "", + "authorization": "token MYTOKEN", "user-agent": "GitHub CLI v1.2.3", "accept": "", }, wantStderr: "", }, + { + name: "github.com no authentication token", + args: args{ + config: tinyConfig{"example.com:oauth_token": "MYTOKEN"}, + appVersion: "v1.2.3", + setAccept: true, + }, + host: "github.com", + wantHeader: map[string]string{ + "authorization": "", + "user-agent": "GitHub CLI v1.2.3", + "accept": "application/vnd.github.merge-info-preview+json", + }, + wantStderr: "", + }, { name: "github.com in verbose mode", args: args{ config: tinyConfig{"github.com:oauth_token": "MYTOKEN"}, appVersion: "v1.2.3", - setAccept: false, + setAccept: true, }, host: "github.com", envDebug: "api", wantHeader: map[string]string{ "authorization": "token MYTOKEN", "user-agent": "GitHub CLI v1.2.3", - "accept": "", + "accept": "application/vnd.github.merge-info-preview+json", }, wantStderr: heredoc.Doc(` * Request at