From 500b619a5e7b388af89370c0f1fbba338aa5383f Mon Sep 17 00:00:00 2001 From: Cody Soyland Date: Fri, 6 Sep 2024 13:55:25 -0400 Subject: [PATCH] Move non-integration test to different test file Signed-off-by: Cody Soyland --- pkg/cmd/attestation/verification/attestation_test.go | 12 ++++++++++++ .../verification/sigstore_integration_test.go | 10 ---------- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/pkg/cmd/attestation/verification/attestation_test.go b/pkg/cmd/attestation/verification/attestation_test.go index a3f444572..0795f053c 100644 --- a/pkg/cmd/attestation/verification/attestation_test.go +++ b/pkg/cmd/attestation/verification/attestation_test.go @@ -87,6 +87,18 @@ func TestGetLocalAttestations(t *testing.T) { require.ErrorIs(t, err, ErrUnrecognisedBundleExtension) require.Nil(t, attestations) }) + + t.Run("with missing verification material", func(t *testing.T) { + path := "../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-verification-material.jsonl" + _, err := GetLocalAttestations(path) + require.ErrorContains(t, err, "missing verification material") + }) + + t.Run("with missing verification certificate", func(t *testing.T) { + path := "../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-cert.jsonl" + _, err := GetLocalAttestations(path) + require.ErrorContains(t, err, "missing bundle content") + }) } func TestFilterAttestations(t *testing.T) { diff --git a/pkg/cmd/attestation/verification/sigstore_integration_test.go b/pkg/cmd/attestation/verification/sigstore_integration_test.go index e56e7d1ed..97b44581e 100644 --- a/pkg/cmd/attestation/verification/sigstore_integration_test.go +++ b/pkg/cmd/attestation/verification/sigstore_integration_test.go @@ -42,16 +42,6 @@ func TestLiveSigstoreVerifier(t *testing.T) { require.NoError(t, res.Error) }) - t.Run("with missing verification material", func(t *testing.T) { - _, err := GetLocalAttestations("../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-verification-material.jsonl") - require.ErrorContains(t, err, "missing verification material") - }) - - t.Run("with missing verification certificate", func(t *testing.T) { - _, err := GetLocalAttestations("../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-cert.jsonl") - require.ErrorContains(t, err, "missing bundle content") - }) - t.Run("with GitHub Sigstore artifact", func(t *testing.T) { githubArtifactPath := test.NormalizeRelativePath("../test/data/github_provenance_demo-0.0.12-py3-none-any.whl") githubArtifact, err := artifact.NewDigestedArtifact(nil, githubArtifactPath, "sha256")