From 51196265cc36148e110dc31cc32cdd3d32260d05 Mon Sep 17 00:00:00 2001 From: vilmibm Date: Tue, 2 Jun 2020 13:48:19 -0500 Subject: [PATCH] update note --- command/alias.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/command/alias.go b/command/alias.go index 7834ea597..63e122bf4 100644 --- a/command/alias.go +++ b/command/alias.go @@ -21,10 +21,10 @@ var aliasCmd = &cobra.Command{ var aliasSetCmd = &cobra.Command{ Use: "set ", - // TODO HACK: even when inside of a single-quoted string, cobra was noticing and parsing any flags + // NB: Even when inside of a single-quoted string, cobra was noticing and parsing any flags // used in an alias expansion string argument. Since this command needs no flags, I disabled their - // parsing. If we ever want to add flags to alias set we'll have to figure this out. I haven't - // checked if this is fixed in a new cobra. + // parsing. If we ever want to add flags to alias set we'll have to figure this out. I tested on + // linux in various shells against cobra 1.0; others on macos did /not/ see the same behavior. DisableFlagParsing: true, Short: "Create a shortcut for a gh command", Long: `