From 52eca968733ccbff720483a375bff2367ba6bad4 Mon Sep 17 00:00:00 2001 From: "Babak K. Shandiz" Date: Tue, 17 Feb 2026 11:46:27 +0000 Subject: [PATCH] refactor(featuredetection): remove temp in favour of early returns Signed-off-by: Babak K. Shandiz --- .../featuredetection/feature_detection.go | 34 ++++++++++--------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/internal/featuredetection/feature_detection.go b/internal/featuredetection/feature_detection.go index 2f7b6255a..b2fb6d65d 100644 --- a/internal/featuredetection/feature_detection.go +++ b/internal/featuredetection/feature_detection.go @@ -425,28 +425,30 @@ func (d *detector) ActionsFeatures() (ActionsFeatures, error) { // going to be ignored/removed. So, once we are migrating to the new API version we should double check the status // of the API. - var dispatchRunDetailsSupported bool - if !ghauth.IsEnterprise(d.host) { - dispatchRunDetailsSupported = true - } else { - minSupportedVersion, err := version.NewVersion(enterpriseWorkflowDispatchRunDetailsSupport) - if err != nil { - return ActionsFeatures{}, err - } + return ActionsFeatures{ + DispatchRunDetails: true, + }, nil + } - hostVersion, err := resolveEnterpriseVersion(d.httpClient, d.host) - if err != nil { - return ActionsFeatures{}, err - } + minSupportedVersion, err := version.NewVersion(enterpriseWorkflowDispatchRunDetailsSupport) + if err != nil { + return ActionsFeatures{}, err + } - if hostVersion.GreaterThanOrEqual(minSupportedVersion) { - dispatchRunDetailsSupported = true - } + hostVersion, err := resolveEnterpriseVersion(d.httpClient, d.host) + if err != nil { + return ActionsFeatures{}, err + } + + if hostVersion.GreaterThanOrEqual(minSupportedVersion) { + return ActionsFeatures{ + DispatchRunDetails: true, + }, nil } return ActionsFeatures{ - DispatchRunDetails: dispatchRunDetailsSupported, + DispatchRunDetails: false, }, nil }