From 58d3aa878da296233c2ee15dbd409824a8f2327e Mon Sep 17 00:00:00 2001 From: Luke Adams Date: Mon, 19 Apr 2021 10:59:36 -0600 Subject: [PATCH] Extract filename creation logic to seperate function --- pkg/cmd/run/view/view.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/run/view/view.go b/pkg/cmd/run/view/view.go index 98b1823ec..9f8451b82 100644 --- a/pkg/cmd/run/view/view.go +++ b/pkg/cmd/run/view/view.go @@ -461,6 +461,11 @@ func promptForJob(cs *iostreams.ColorScheme, jobs []shared.Job) (*shared.Job, er return nil, nil } +func createLogFilename(job shared.Job, step shared.Step) string { + return fmt.Sprintf("%s/%d_%s.txt", job.Name, step.Number, + strings.ReplaceAll(step.Name, "/", "")) +} + // This function takes a zip file of logs and a list of jobs. // Structure of zip file // zip/ @@ -478,8 +483,7 @@ func promptForJob(cs *iostreams.ColorScheme, jobs []shared.Job) (*shared.Job, er func attachRunLog(rlz *zip.ReadCloser, jobs []shared.Job) { for i, job := range jobs { for j, step := range job.Steps { - filename := fmt.Sprintf("%s/%d_%s.txt", job.Name, step.Number, - strings.ReplaceAll(step.Name, "/", "")) + filename := createLogFilename(job, step) for _, file := range rlz.File { if file.Name == filename { jobs[i].Steps[j].Log = file