From c7f79e844708d4d6989ed3c75613a23c3dfe83f1 Mon Sep 17 00:00:00 2001 From: Tomohiro Nishimura Date: Tue, 19 Oct 2021 22:37:16 +0900 Subject: [PATCH 1/2] Set default publish action to draft if --draft option is set --- pkg/cmd/release/create/create.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/cmd/release/create/create.go b/pkg/cmd/release/create/create.go index 66e4bead3..928056bb4 100644 --- a/pkg/cmd/release/create/create.go +++ b/pkg/cmd/release/create/create.go @@ -241,6 +241,11 @@ func createRun(opts *CreateOptions) error { opts.Body = text } + var defaultSubmit string + if opts.Draft { + defaultSubmit = "Save as draft" + } + qs = []*survey.Question{ { Name: "prerelease", @@ -258,6 +263,7 @@ func createRun(opts *CreateOptions) error { "Save as draft", "Cancel", }, + Default: defaultSubmit, }, }, } From 2135918c4764233d262bc626753e4607f3a4145d Mon Sep 17 00:00:00 2001 From: Sam Coe Date: Tue, 19 Oct 2021 08:55:30 -0700 Subject: [PATCH 2/2] Turn survey options into variables so they can't accidentally become unsynced with default value --- pkg/cmd/release/create/create.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/cmd/release/create/create.go b/pkg/cmd/release/create/create.go index 928056bb4..0265229b5 100644 --- a/pkg/cmd/release/create/create.go +++ b/pkg/cmd/release/create/create.go @@ -241,9 +241,11 @@ func createRun(opts *CreateOptions) error { opts.Body = text } - var defaultSubmit string + saveAsDraft := "Save as draft" + publishRelease := "Publish release" + defaultSubmit := publishRelease if opts.Draft { - defaultSubmit = "Save as draft" + defaultSubmit = saveAsDraft } qs = []*survey.Question{ @@ -259,8 +261,8 @@ func createRun(opts *CreateOptions) error { Prompt: &survey.Select{ Message: "Submit?", Options: []string{ - "Publish release", - "Save as draft", + publishRelease, + saveAsDraft, "Cancel", }, Default: defaultSubmit,