fixing mistake
This commit is contained in:
parent
aac4c59c31
commit
5e3ca02198
1 changed files with 9 additions and 12 deletions
|
|
@ -3,7 +3,6 @@ package browse
|
|||
import (
|
||||
"fmt"
|
||||
"net/http"
|
||||
"os"
|
||||
"testing"
|
||||
|
||||
"github.com/cli/cli/internal/ghrepo"
|
||||
|
|
@ -135,7 +134,6 @@ func TestNewCmdBrowse(t *testing.T) {
|
|||
}
|
||||
|
||||
func Test_runBrowse(t *testing.T) {
|
||||
s := string(os.PathSeparator)
|
||||
tests := []struct {
|
||||
name string
|
||||
opts BrowseOptions
|
||||
|
|
@ -259,7 +257,7 @@ func Test_runBrowse(t *testing.T) {
|
|||
{
|
||||
name: "relative path from browse_test.go",
|
||||
opts: BrowseOptions{
|
||||
SelectorArg: "." + s + "browse_test.go",
|
||||
SelectorArg: "./browse_test.go",
|
||||
},
|
||||
baseRepo: ghrepo.New("bchadwic", "gh-graph"),
|
||||
defaultBranch: "trunk",
|
||||
|
|
@ -269,7 +267,7 @@ func Test_runBrowse(t *testing.T) {
|
|||
{
|
||||
name: "relative path to file in parent folder from browse_test.go",
|
||||
opts: BrowseOptions{
|
||||
SelectorArg: ".." + s + "pr",
|
||||
SelectorArg: "../pr",
|
||||
},
|
||||
baseRepo: ghrepo.New("bchadwic", "gh-graph"),
|
||||
defaultBranch: "trunk",
|
||||
|
|
@ -359,7 +357,6 @@ func Test_parseFileArg(t *testing.T) {
|
|||
|
||||
func Test_parsePathFromFileArg(t *testing.T) {
|
||||
|
||||
s := string(os.PathSeparator)
|
||||
// tests assume path is pkg/cmd/browse
|
||||
tests := []struct {
|
||||
name string
|
||||
|
|
@ -368,27 +365,27 @@ func Test_parsePathFromFileArg(t *testing.T) {
|
|||
}{
|
||||
{
|
||||
name: "go to parent folder",
|
||||
fileArg: ".." + s,
|
||||
fileArg: "../",
|
||||
expectedPath: "pkg/cmd",
|
||||
},
|
||||
{
|
||||
name: "file in current folder",
|
||||
fileArg: "." + s + "browse.go",
|
||||
fileArg: "./browse.go",
|
||||
expectedPath: "pkg/cmd/browse/browse.go",
|
||||
},
|
||||
{
|
||||
name: "file within parent folder",
|
||||
fileArg: ".." + s + "browse.go",
|
||||
fileArg: "../browse.go",
|
||||
expectedPath: "pkg/cmd/browse.go",
|
||||
},
|
||||
{
|
||||
name: "file within parent folder uncleaned",
|
||||
fileArg: ".." + s + "." + s + s + s + "browse.go",
|
||||
fileArg: ".././//browse.go",
|
||||
expectedPath: "pkg/cmd/browse.go",
|
||||
},
|
||||
{
|
||||
name: "different path from root directory",
|
||||
fileArg: ".." + s + ".." + s + ".." + s + "internal/build/build.go",
|
||||
fileArg: "../../../internal/build/build.go",
|
||||
expectedPath: "internal/build/build.go",
|
||||
},
|
||||
{
|
||||
|
|
@ -403,12 +400,12 @@ func Test_parsePathFromFileArg(t *testing.T) {
|
|||
},
|
||||
{
|
||||
name: "go out of repository",
|
||||
fileArg: ".." + s + ".." + s + ".." + s + ".." + s + ".." + s + ".." + s + "",
|
||||
fileArg: "../../../../../../",
|
||||
expectedPath: "",
|
||||
},
|
||||
{
|
||||
name: "go to root of repository",
|
||||
fileArg: ".." + s + ".." + s + ".." + s + "",
|
||||
fileArg: "../../../",
|
||||
expectedPath: "",
|
||||
},
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue