From 601cf888523f02e8c0b6abe3f03030e702b577c1 Mon Sep 17 00:00:00 2001 From: Tyler McGoffin Date: Fri, 31 Jan 2025 14:37:19 -0800 Subject: [PATCH] Handle error from ParsePRRefs when the selector is provided --- pkg/cmd/pr/shared/finder.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/pr/shared/finder.go b/pkg/cmd/pr/shared/finder.go index 0ba3ec734..332baa857 100644 --- a/pkg/cmd/pr/shared/finder.go +++ b/pkg/cmd/pr/shared/finder.go @@ -201,7 +201,11 @@ func (f *finder) Find(opts FindOptions) (*api.PullRequest, ghrepo.Interface, err f.prNumber = prNumber } else { f.branchName = opts.Selector - prRefs, _ = ParsePRRefs(f.branchName, git.BranchConfig{}, "", "", "", f.baseRefRepo, remotes.Remotes{}) + // We don't expect an error here because parsedPushRevision is empty + prRefs, err = ParsePRRefs(f.branchName, git.BranchConfig{}, "", "", "", f.baseRefRepo, remotes.Remotes{}) + if err != nil { + return nil, nil, err + } } }