From 6355ed7c08e1a6a76cb10b5b461750cdee034dcb Mon Sep 17 00:00:00 2001 From: William Martin Date: Fri, 24 Jan 2025 17:25:38 +0100 Subject: [PATCH] WIP: push default defaults to simple --- pkg/cmd/pr/shared/finder.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/pr/shared/finder.go b/pkg/cmd/pr/shared/finder.go index 4aa58af96..57db40a85 100644 --- a/pkg/cmd/pr/shared/finder.go +++ b/pkg/cmd/pr/shared/finder.go @@ -59,7 +59,17 @@ func NewFinder(factory *cmdutil.Factory) PRFinder { remotesFn: factory.Remotes, httpClient: factory.HttpClient, pushDefault: func() (string, error) { - return factory.GitClient.Config(context.Background(), "push.default") + pushDefault, err := factory.GitClient.Config(context.Background(), "push.default") + if err == nil { + return pushDefault, nil + } + + var gitErr *git.GitError + if ok := errors.As(err, &gitErr); ok && gitErr.ExitCode == 1 { + return "simple", nil + } + + return "", err }, progress: factory.IOStreams, branchConfig: func(s string) (git.BranchConfig, error) {