From 65d11247996d60ade6865831365933dbeecd7f33 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mislav=20Marohni=C4=87?= <mislav@github.com>
Date: Tue, 3 Aug 2021 16:46:04 +0200
Subject: [PATCH] Close file after resolving faux symlinks on Windows

https://github.com/cli/cli/pull/4051/checks?check_run_id=3186063173
---
 pkg/cmd/extensions/manager.go | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/pkg/cmd/extensions/manager.go b/pkg/cmd/extensions/manager.go
index cc3c07790..fe93c1caa 100644
--- a/pkg/cmd/extensions/manager.go
+++ b/pkg/cmd/extensions/manager.go
@@ -108,16 +108,11 @@ func (m *Manager) list(includeMetadata bool) ([]extensions.Extension, error) {
 			isLocal = true
 			if f.Mode()&os.ModeSymlink == 0 {
 				// if this is a regular file, its contents is the local directory of the extension
-				exeFile, err := os.Open(filepath.Join(dir, f.Name()))
+				p, err := readPathFromFile(filepath.Join(dir, f.Name()))
 				if err != nil {
 					return nil, err
 				}
-				b := make([]byte, 1024)
-				n, err := exeFile.Read(b)
-				if err != nil {
-					return nil, err
-				}
-				exePath = filepath.Join(strings.TrimSpace(string(b[:n])), f.Name())
+				exePath = filepath.Join(p, f.Name())
 			}
 		}
 		results = append(results, &Extension{
@@ -272,3 +267,14 @@ func runCmds(cmds []*exec.Cmd, stdout, stderr io.Writer) error {
 	}
 	return nil
 }
+
+func readPathFromFile(path string) (string, error) {
+	f, err := os.Open(path)
+	if err != nil {
+		return "", err
+	}
+	defer f.Close()
+	b := make([]byte, 1024)
+	n, err := f.Read(b)
+	return strings.TrimSpace(string(b[:n])), err
+}