From 66fae72872c27037e15df92ae7a12da7ceb718f5 Mon Sep 17 00:00:00 2001 From: Kynan Ware <47394200+BagToad@users.noreply.github.com> Date: Wed, 1 Oct 2025 16:12:06 -0600 Subject: [PATCH] Remove default empty slices in RemovePullRequestReviews Eliminates unnecessary initialization of users and teams to empty slices in RemovePullRequestReviews. Also updates the request body struct to use 'omitempty' for reviewers and team_reviewers, ensuring empty fields are omitted from the JSON payload. --- api/queries_pr.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/api/queries_pr.go b/api/queries_pr.go index 010a915e2..4262738c3 100644 --- a/api/queries_pr.go +++ b/api/queries_pr.go @@ -664,13 +664,6 @@ func RemovePullRequestReviews(client *Client, repo ghrepo.Interface, prNumber in return nil } - if users == nil { - users = []string{} - } - if teams == nil { - teams = []string{} - } - path := fmt.Sprintf( "repos/%s/%s/pulls/%d/requested_reviewers", url.PathEscape(repo.RepoOwner()), @@ -678,8 +671,8 @@ func RemovePullRequestReviews(client *Client, repo ghrepo.Interface, prNumber in prNumber, ) body := struct { - Reviewers []string `json:"reviewers"` - TeamReviewers []string `json:"team_reviewers"` + Reviewers []string `json:"reviewers,omitempty"` + TeamReviewers []string `json:"team_reviewers,omitempty"` }{ Reviewers: users, TeamReviewers: teams,